Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: "Bystricky, Juro" <juro.bystricky@intel.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Cc: "jurobystricky@hotmail.com" <jurobystricky@hotmail.com>
Subject: Re: [PATCH] glib-2.0/glib.inc: fix broken mingw build
Date: Fri, 13 Apr 2018 22:32:05 +0300	[thread overview]
Message-ID: <5c94de57-180e-d723-f5cb-135aefd8790a@linux.intel.com> (raw)
In-Reply-To: <6E51916E4A1F32428260031F4C7CD2B64C6A8201@ORSMSX112.amr.corp.intel.com>

On 04/13/2018 05:43 PM, Bystricky, Juro wrote:
>> I think the better approach is to accommodate the exe suffix when doing
>> the move:
> 
>> mv -v ${D}${libexecdir}/gio-querymodules${EXEEXT}
>> ${D}${libexecdir}/${MLPREFIX}gio-querymodules${EXEEXT}
> 
> This was actually the first thing I tried. However, I ended up with "nativesdk-gio-querymodules.exe"
> in the mingw tarrball (in my case poky-glibc-x86_64-core-image-minimal-core2-64-toolchain-2.4+snapshot.tar.xz).
> I am not sure what you expect postinst to do for Windows toolchains/SDKs, but I would expect
> "gio-querymodules.exe", as it used to be until recently.

"nativesdk-gio-querymodules.exe" is totally fine. This utility is used 
in only one place:
poky/scripts/postinst-intercepts/update_gio_module_cache, to generate 
the cache file of gio modules whenever the gio modules are installed or 
removed.

That script is called by postinst_intercept mechanism, which is 
triggered via meta/classes/gio-module-cache.bbclass every time a package 
that inherits that class is installed.

I am fairly sure that with the patch you sent it is not going to work 
for the nativesdk mingw case, as the script does prepend the MLPREFIX to 
the utility name (to call the correct version among many when multilib 
is in use). We would probably need to append the .exe suffix in there as 
well though.

Please do try populate_sdk with nativesdk-glib-2.0 included into it and 
watch for any warnings about failed postinst_intercepts.

Alex


  reply	other threads:[~2018-04-13 19:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 22:28 [PATCH] glib-2.0/glib.inc: fix broken mingw build Juro Bystricky
2018-04-13  6:48 ` Alexander Kanavin
2018-04-13 14:43   ` Bystricky, Juro
2018-04-13 19:32     ` Alexander Kanavin [this message]
2018-04-13 20:29       ` Bystricky, Juro
2018-04-13 21:03         ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c94de57-180e-d723-f5cb-135aefd8790a@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=juro.bystricky@intel.com \
    --cc=jurobystricky@hotmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox