Re: [PATCH] waffle: prefix MLPREFIX on libgl dependency

[Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>]

leonardo.sandoval.gonzalez@linux.intel.com writes:

please ignore this patch. I will git-amend and provide a better explanation.

> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Otherwise, on a multilib environment we get the following bitbake errors
> while building 'world'
>
>     ERROR: Nothing PROVIDES 'virtual/lib32-libgl' (but virtual:multilib:lib32:/meta/recipes-graphics/waffle/waffle_1.5.2.bb DEPENDS on or otherwise requires it). Close matches:
>       virtual/lib32-libsdl
>       virtual/lib32-libc
>       virtual/lib32-libsdl2
>     ERROR: Required build target 'lib32-meta-world-pkgdata' has no buildable providers.
>     Missing or unbuildable dependency chain was: ['lib32-meta-world-pkgdata', 'meta-world-pkgdata', 'lib32-waffle', 'virtual/lib32-libgl']
>
>     Summary: There were 2 ERROR messages shown, returning a non-zero exit code.
>
> [YOCTO #10900]
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> ---
>  meta/recipes-graphics/waffle/waffle_1.5.2.bb | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-graphics/waffle/waffle_1.5.2.bb b/meta/recipes-graphics/waffle/waffle_1.5.2.bb
> index 9d6b0e0e0d..a5179db1da 100644
> --- a/meta/recipes-graphics/waffle/waffle_1.5.2.bb
> +++ b/meta/recipes-graphics/waffle/waffle_1.5.2.bb
> @@ -21,20 +21,20 @@ PACKAGECONFIG ??= "glx"
>  REQUIRED_DISTRO_FEATURES = "${@bb.utils.contains('PACKAGECONFIG', 'glx', 'x11', '', d)}"
>  
>  # virtual/libgl requires opengl in DISTRO_FEATURES.
> -REQUIRED_DISTRO_FEATURES += "${@bb.utils.contains('DEPENDS', 'virtual/libgl', 'opengl', '', d)}"
> +REQUIRED_DISTRO_FEATURES += "${@bb.utils.contains('DEPENDS', 'virtual/${MLPREFIX}libgl', 'opengl', '', d)}"
>  
>  # I say virtual/libgl, actually wants gl.pc
> -PACKAGECONFIG[glx] = "-Dwaffle_has_glx=1,-Dwaffle_has_glx=0,virtual/libgl libx11"
> +PACKAGECONFIG[glx] = "-Dwaffle_has_glx=1,-Dwaffle_has_glx=0,virtual/${MLPREFIX}libgl libx11"
>  
>  # I say virtual/libgl, actually wants wayland-egl.pc, egl.pc, and the wayland
>  # DISTRO_FEATURE.
> -PACKAGECONFIG[wayland] = "-Dwaffle_has_wayland=1,-Dwaffle_has_wayland=0,virtual/libgl wayland"
> +PACKAGECONFIG[wayland] = "-Dwaffle_has_wayland=1,-Dwaffle_has_wayland=0,virtual/${MLPREFIX}libgl wayland"
>  
>  # I say virtual/libgl, actually wants gbm.pc egl.pc
> -PACKAGECONFIG[gbm] = "-Dwaffle_has_gbm=1,-Dwaffle_has_gbm=0,virtual/libgl udev"
> +PACKAGECONFIG[gbm] = "-Dwaffle_has_gbm=1,-Dwaffle_has_gbm=0,virtual/${MLPREFIX}libgl udev"
>  
>  # I say virtual/libgl, actually wants egl.pc
> -PACKAGECONFIG[x11-egl] = "-Dwaffle_has_x11_egl=1,-Dwaffle_has_x11_egl=0,virtual/libgl libxcb"
> +PACKAGECONFIG[x11-egl] = "-Dwaffle_has_x11_egl=1,-Dwaffle_has_x11_egl=0,virtual/${MLPREFIX}libgl libxcb"
>  
>  FILES_${PN}-dev += "${datadir}/cmake/Modules/FindWaffle.cmake \
>                      ${libdir}/cmake/Waffle/"