Re: [OE-Core][PATCH 1/4] testimage: create a list of failed test post actions

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2024-02-21 at 08:53 +0100, Alexis Lothoré wrote:
> On 2/21/24 08:34, Richard Purdie wrote:
> > On Tue, 2024-02-20 at 21:01 +0100, Alexis Lothoré via
> > lists.openembedded.org wrote:
> > > From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> [...]
> 
> > > +################################################################
> > > ##
> > > +# General post actions runner
> > > +################################################################
> > > ##
> > > +
> > > +def run_failed_tests_post_actions(d, tc):
> > > +    post_actions=[
> > > +        list_and_fetch_failed_tests_artifacts
> > > +    ]
> > > +
> > > +    for action in post_actions:
> > > +        action(d, tc)
> > 
> > Rather than create a bbclass class of python functions, these
> > should
> > move to lib/oe and become a proper python library file?
> 
> ACK, I will do that and create a proper python file for this.
> 
> > Moving functions out of the class files is on my long term todo
> > list so
> > this seems like an idea opportunity.
> 
> So should this series take the opportunity to move all already
> existing python
> functions from testimage to a lib ? I can certainly do that if that's
> your point :)

I'm saying over time I think many of the python functions need to move.
This close to feature freeze may not be the best time, I just wanted to
give a clear view of my intent.

Sometimes the variable dependencies don't work the same way from the
python library so we need to be careful.

Cheers,

Richard