From: alexander.kanavin@linux.intel.com
To: "Aníbal Limón" <anibal.limon@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 25/26] distrodata.bbclass: do not use get_recipe_pv_without_srcpv() before comparing versions in checkpkg
Date: Fri, 31 Jul 2015 22:45:41 +0300 (EEST) [thread overview]
Message-ID: <61426.10.252.34.83.1438371941.squirrel@linux.intel.com> (raw)
In-Reply-To: <55BB9568.3020305@linux.intel.com>
>>> re.compile("(?P<pfx>(v|))(?P<ver>((\d+[\.\-_]*)+))(?P<sfx>(\+|)(git|)(r|)(AUTOINC|)(\+|))(?P<rev>.*)")
>>> regex = re.compile("(?P<pfx>(v|r|))(?P<ver>((\d+[\.\-_]*)+))")
> I made a mistake here the case that i say is when have a prefix like,
>
> >>> import bb
> >>> bb.utils.vercmp_string('r2.7+gitX', '2.9+gitX')
But the <pfx> component should take care of any such leading characters,
right? So when they are taken out, there is no reason to limit the rest to
just numbers. I'll send a patch which changes the regexes to allow "pre",
"rc", "final", "stable", or anything else like "1.0.2a". We can't hardcode
everything that people can come up with, so it's best to write a generic
regex.
Alex
next prev parent reply other threads:[~2015-07-31 19:46 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 13:31 [PATCH 00/26] Upstream version check fixes for various recipes Alexander Kanavin
2015-07-30 13:31 ` [PATCH 01/26] libproxy: update SRC_URI to not use Google Code Alexander Kanavin
2015-07-30 14:29 ` Martin Jansa
2015-07-30 14:29 ` Burton, Ross
2015-07-30 15:12 ` Alexander Kanavin
2015-07-30 15:20 ` Burton, Ross
2015-07-30 13:31 ` [PATCH 02/26] fotowall: update SRC_URI to use github instead of qt-apps.org Alexander Kanavin
2015-07-30 14:29 ` Martin Jansa
2015-07-30 15:14 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 03/26] distcc: update SRC_URI to not use Google Code Alexander Kanavin
2015-07-30 14:30 ` Martin Jansa
2015-07-30 13:31 ` [PATCH 04/26] adt-installer: " Alexander Kanavin
2015-07-30 13:31 ` [PATCH 05/26] ossp-uuid: " Alexander Kanavin
2015-07-30 13:31 ` [PATCH 06/26] eglinfo: change version from 1.0 to 1.0.0 to match the upstream git tag Alexander Kanavin
2015-07-30 14:31 ` Martin Jansa
2015-07-30 15:02 ` Burton, Ross
2015-07-30 15:18 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 07/26] gptfdisk: use tarballs instead of git for fetching source code Alexander Kanavin
2015-07-30 13:31 ` [PATCH 08/26] libmad: use ftp instead of sourceforge for consistency with libid3tag Alexander Kanavin
2015-07-30 13:31 ` [PATCH 09/26] lsb: set PV to 1.4 to match upstream tarball version Alexander Kanavin
2015-07-30 14:32 ` Martin Jansa
2015-07-30 15:22 ` Alexander Kanavin
2015-08-07 7:21 ` Khem Raj
2015-08-07 12:09 ` Alexander Kanavin
2015-08-07 19:22 ` Khem Raj
2015-07-30 13:31 ` [PATCH 10/26] linux-yocto-dev: only numeric characters are allowed in package versions taken from git Alexander Kanavin
2015-07-30 13:31 ` [PATCH 11/26] nss: reorder SRC_URI lines to fix upstream version check Alexander Kanavin
2015-07-30 14:33 ` Martin Jansa
2015-07-30 15:04 ` Burton, Ross
2015-07-30 16:04 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 12/26] pseudo: fix upstream SRC_URI to enable " Alexander Kanavin
2015-07-30 13:31 ` [PATCH 13/26] oprofile: reorder SRC_URI lines to fix " Alexander Kanavin
2015-07-30 14:34 ` Martin Jansa
2015-07-30 15:41 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 14/26] puzzles: switch svn for git, as upstream has done the same Alexander Kanavin
2015-07-30 14:35 ` Martin Jansa
2015-07-30 16:06 ` Alexander Kanavin
2015-08-07 7:19 ` Khem Raj
2015-08-07 12:08 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 15/26] syslinux: drop v6.xx/ from directory path in SRC_URI Alexander Kanavin
2015-07-30 13:31 ` [PATCH 16/26] shared-mime-info: reorder SRC_URI lines to fix upstream version check Alexander Kanavin
2015-07-30 13:31 ` [PATCH 17/26] tremor: switch SRC_URI from svn to tarballs on debian mirrors Alexander Kanavin
2015-07-30 14:35 ` Martin Jansa
2015-07-30 13:31 ` [PATCH 18/26] x264: only numeric characters are allowed in package versions taken from git Alexander Kanavin
2015-07-30 13:31 ` [PATCH 19/26] xf86-video-omapfb: switch SRC_URI to debian git repo Alexander Kanavin
2015-07-30 21:03 ` Burton, Ross
2015-07-30 13:31 ` [PATCH 20/26] stress: use developer's website for SRC_URI Alexander Kanavin
2015-07-30 17:45 ` Max Krummenacher
2015-07-31 12:17 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 21/26] systemd: remove PV from the recipe Alexander Kanavin
2015-07-30 14:36 ` Martin Jansa
2015-07-30 15:32 ` Alexander Kanavin
2015-07-30 16:25 ` Burton, Ross
2015-07-30 16:35 ` Alexander Kanavin
2015-07-31 12:40 ` Pascal Bach
2015-07-31 12:53 ` Alexander Kanavin
2015-07-31 13:03 ` Pascal Bach
2015-07-31 13:03 ` Alexander Kanavin
2015-07-31 12:24 ` Alexander Kanavin
2015-07-30 13:31 ` [PATCH 22/26] unzip, zip: fix PV to allow upstream version check Alexander Kanavin
2015-07-30 13:31 ` [PATCH 23/26] guilt-native: set PV in the recipe " Alexander Kanavin
2015-07-30 13:31 ` [PATCH 24/26] distrodata.bbclass: do not skip -native recipes in checkpkg task Alexander Kanavin
2015-07-30 13:31 ` [PATCH 25/26] distrodata.bbclass: do not use get_recipe_pv_without_srcpv() before comparing versions in checkpkg Alexander Kanavin
2015-07-31 14:54 ` Aníbal Limón
2015-07-31 15:09 ` Alexander Kanavin
2015-07-31 15:31 ` Aníbal Limón
2015-07-31 15:34 ` Aníbal Limón
2015-07-31 19:45 ` alexander.kanavin [this message]
2015-07-30 13:31 ` [PATCH 26/26] distrodata.bbclass: drop the manual upstream version check logic Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61426.10.252.34.83.1438371941.squirrel@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=anibal.limon@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox