Re: [OE-core] [PATCHv2 1/4] pseudo: Simplify pseudo_client_ignore_path_chroot()

["Peter Kjellerstedt" <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 30 november 2020 12:47
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCHv2 1/4] pseudo: Simplify
> pseudo_client_ignore_path_chroot()
> 
> Hi Peter,
> 
> On Wed, 2020-11-25 at 14:48 +0100, Peter Kjellerstedt wrote:
> > This also plugs a memory leak in pseudo_client_ignore_path_chroot().
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> 
> I make no claim to understand what happened but I tried patches 1 and 2
> in a build over the weekend and with the first two present:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/1602
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/1584
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/1586
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/1610
> 
> I then removed this one leaving only patch 2 and the build was fine.
> 
> So there is something odd in this patch but I've not looked into what
> or why only selftest is affected.
> 
> Cheers,
> 
> Richard

I believe I have found the problem. I had missed the edge case where 
two commas are specified immediately after each other, or there is a
leading/trailing comma. This would effectively cause pseudo to ignore 
all paths. Thankfully the fix is trivial.

I have verified that I could repeat the oe-selftest problems for the 
wic.Wic2 tests, and that they are back to working with my updated 
code.

I will wait with sending an updated patch series until I have a 
response regarding how you want me to handle the third patch in 
the series (see my other mail from earlier today).

//Peter