public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Pierre-loup GOSSE" <pierre-loup.gosse@smile.fr>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v4 6/6] wic: extra-partitions: extend to support extra directories
Date: Thu, 15 Jan 2026 08:41:16 -0800	[thread overview]
Message-ID: <62316.1768495276423528313@lists.openembedded.org> (raw)
In-Reply-To: <CAHT-cZvh=aH5gyDbR0eE3ZQn3FJ=i=SQQtHhU+swZeXnLnUyBA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

I missed one point,

Using logger.info in the _parse_extra functions would be more suitable when the variable is unset.
Since a WicError is raised if both variables are unset, displaying a warning when only one of the two variables is set could be unnecessary and annoying.

Thanks,

Pierre-Loup

[-- Attachment #2: Type: text/html, Size: 588 bytes --]

      reply	other threads:[~2026-01-15 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 10:14 [PATCH v4 1/6] wic: extra-partition: Small code cleanup Adam Duskett
2026-01-15 10:14 ` [PATCH v4 2/6] wic: extra-partition: Move extra file parsing to a dedicated method Adam Duskett
2026-01-15 10:14 ` [PATCH v4 3/6] wic: extra-partition: Move extra var handling " Adam Duskett
2026-01-15 10:14 ` [PATCH v4 4/6] wic: extra-partition: Rename install_task to extra_files_task Adam Duskett
2026-01-15 10:14 ` [PATCH v4 5/6] wic: extra-partitions: move extra-files WicError to do_prepare_partition Adam Duskett
2026-01-15 10:14 ` [PATCH v4 6/6] wic: extra-partitions: extend to support extra directories Adam Duskett
2026-01-15 14:55   ` [OE-core] " Pierre-loup GOSSE
2026-01-15 16:41     ` Pierre-loup GOSSE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62316.1768495276423528313@lists.openembedded.org \
    --to=pierre-loup.gosse@smile.fr \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox