public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Jacob Kroon <jacob.kroon@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES
Date: Mon, 16 May 2022 13:38:35 +0100	[thread overview]
Message-ID: <63b10a5b05a1a029e50725341b1cb5cf4838ac53.camel@linuxfoundation.org> (raw)
In-Reply-To: <7763f240-35b1-27d8-f2ec-8860dbea0e48@gmail.com>

On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote:
> Hi Richard,
> 
> On 5/16/22 13:28, Richard Purdie wrote:
> > Using += unintentionally removes all over entries from DISTRO_FEATURES and
> 
> "over", you mean "other" ? If so, how is that possible ?

I mean other, I'll fix the typo. It happens due to:

meta-poky/conf/distro/poky.conf:DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT} ${POKY_DEFAULT_DISTRO_FEATURES}"

which interacts badly with "+=" :(

I'm not happy about the situation with variable interactions but still
not entirely sure the best way to proceed.

Cheers,

Richard


  reply	other threads:[~2022-05-16 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 11:28 [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES Richard Purdie
2022-05-16 11:43 ` [OE-core] " Jacob Kroon
2022-05-16 12:38   ` richard.purdie [this message]
2022-05-16 12:52     ` Jacob Kroon
2022-05-16 12:54       ` richard.purdie
2022-05-16 13:01       ` Quentin Schulz
2022-05-16 13:18         ` Jacob Kroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63b10a5b05a1a029e50725341b1cb5cf4838ac53.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jacob.kroon@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox