Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: Randy Witt <randy.e.witt@linux.intel.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qemu*.conf: Add slirp support for all qemu machines
Date: Wed, 30 Nov 2016 10:00:35 +0800	[thread overview]
Message-ID: <64750cb9-5fbf-e82a-cc74-4f3f13657dd0@windriver.com> (raw)
In-Reply-To: <7b78a4a8-3157-ed82-6efa-1ec699ec8a71@linux.intel.com>



On 11/30/2016 02:24 AM, Randy Witt wrote:
>
>>
>> "-device virtio-net-device,netdev=net0" and
>> "-netdev user,id=net0,hostfwd=tcp::2222-:22"
>>
>> Then there is no way for user to override the second part, and we can't
>> call the first part as a "QB_SLIRP_OPT" since it is only part of them,
>> so I won't break them into 2, and if the user defines QB_SLIRP_OPT
>> in there bsp conf file, then it will be replaced totally.
>>
>
> I'm aware that this will only work for one instance, but currently it doesn't
> work at all and it blocks a high priority bug. The only way to make it 100%
> work, would be to have qemu do the binding of the port to a dynamic one and then
> the user queries it after. Otherwise there is always a window where another
> process could bind to the port.

We can check whether the port is free and use another one if not, we've
already done similar things in runqemu-export-rootfs for nfs, please see:

http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129376.html

// Robert

>
> I don't think the bsp should be in the business of choosing which ports to
> forward. And if it is, then it should be a separate option in the qemuboot.conf,
> with just the "-netdev user" part because otherwise the user will always have to
> modify qemuboot.conf just to forward different ports.
>
> It makes more sense to let the user do something like "runqemu slirp=22,65,..."
> and then return back the actual port used in the forwarding.


>
>


      reply	other threads:[~2016-11-30  2:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 20:11 [PATCH] qemu*.conf: Add slirp support for all qemu machines Randy Witt
2016-11-29  6:21 ` Robert Yang
2016-11-29 18:24   ` Randy Witt
2016-11-30  2:00     ` Robert Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64750cb9-5fbf-e82a-cc74-4f3f13657dd0@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=randy.e.witt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox