Re: [OE-core] [PATCH 1/4] devtool: account for sources in UNPACKDIR

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2025-04-24 at 14:41 +0200, Alexander Kanavin wrote:
> On Thu, 24 Apr 2025 at 14:14, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > > In the two examples above, what is UNPACKDIR set to?
> > 
> > Sorry, let me be more specific. What are the actual values of S and
> > WORKDIR for the different cases?
> 
> Can we step back for a bit? The original error is that 'devtool
> upgrade' breaks cryptically on recipes that set:
> 
> S = "${UNPACKDIR}/git" (instead of the usual WORKDIR/git).
> 
> (everything else being the defaults from oe-core).
> 
> Devtool, in this case, calculates the 'top level source' to be the
> same as UNPACKDIR, and breakage follows.
> 
> An example of such recipe in core is
> meta/recipes-devtools/rpm-sequoia/rpm-sequoia_1.7.0.bb

Stepping back further, we had this mess in devtool in the first place
as it could never work out which files in WORKDIR were "sources" which
it needed to handle carefully.

We now define UNPACKDIR as the place we unpack files to. devtool in
theory can therefore just redefine UNPACKDIR and WORKDIR and things
should 'just work'. The relation of the subpaths between the two should
remain the same.

This should therefore make the code in devtool simpler, not more
complex.

Your patch isn't doing that and I'm wondering if there are code paths
in there which are no longer needed if we handle UNPACKDIR correctly/as
intended.

So in summary, something isn't adding up here to me but I'm not yet
sure quite what.

Cheers,

Richard