Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Watt <jpewhacker@gmail.com>,
	 openembedded-core@lists.openembedded.org
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Subject: Re: [PATCH] classes/sstate: Update output hash
Date: Tue, 15 Jan 2019 22:00:36 +0000	[thread overview]
Message-ID: <66c714be22a43ac8bb38ae7bf735f412efe729d7.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190115193950.25538-1-JPEWhacker@gmail.com>

On Tue, 2019-01-15 at 13:39 -0600, Joshua Watt wrote:
> Updates the output hash calculation for determining if tasks are
> equivalent. The new algorithm does the following based on feedback:
>  1) All files are printed in a single line tabular format
>  2) Prints the file type and mode in a user-friendly ls-like format
>  3) Includes the file owner and group (by name, not ID). These are
> only
>     included if the task is run under pseudo, since that is the only
>     time they can be consistently determined.
>  4) File size is included for regular files
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/classes/sstate.bbclass | 91 +++++++++++++++++++++++++++++++--
> ----
>  1 file changed, 76 insertions(+), 15 deletions(-)

I've not really looked at the code itself yet but could we turn this
into a function in lib/oe/sstate*.py somewhere please?

I'd really like to start getting some of the python code into strong
function libraries where it makes sense and this lends itself toa 
library function.

Cheers,

Richard



  parent reply	other threads:[~2019-01-15 22:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 19:39 [PATCH] classes/sstate: Update output hash Joshua Watt
2019-01-15 20:16 ` Jacob Kroon
2019-01-15 20:49 ` Jacob Kroon
2019-01-15 22:00 ` Richard Purdie [this message]
2019-01-21 22:39 ` [PATCH v2] " Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66c714be22a43ac8bb38ae7bf735f412efe729d7.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jpewhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox