Re: [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

Richard Purdie
2021-03-15T10:49:24Z

On Mon, 2021-03-15 at 10:44 +0000, Luca Boccassi wrote:
> On Sun, 2021-03-14 at 22:10 +0000, Richard Purdie wrote:
> > On Thu, 2021-03-11 at 15:09 +0000, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > >
> > > Recently util-linux gained an (optional) build dependency on libcryptsetup.
> > > But libcryptsetup build-depends on util-linux for blkid (optional, can be disabled)
> > > and uuid (mandatory).
> > > Split out util-linux-uuid in a different recipe to break the cycle.
> > >
> > > https://github.com/karelzak/util-linux/pull/898
> > >
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Unfortunately I noticed we had a performance regression in buildtimes in
> > recent changes. The closest I have this narrowed down to so far:
> >
> > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> >
> > suggests it may be this change. I have more tests queued to confirm
> > that definitively, if so we'll have to figure out why as this shouldn't
> > really happen, its an 8% regression :(.
>
> Very strange that a single recipe could do that - is there something
> wrong in the new .bb that I missed and could cause this?

I'm wondering if it is because we're building util-linux twice now and
there is some key choke point in the dependency chain. I have no evidence
for that yet, it is just speculation though.

Cheers,

Richard