Re: [PATCH v9] util-linux: split uuid in separate recipe to allow bootstrapping

Luca Bocassi
2021-03-11T10:15:06Z

[-- Attachment #1: Type: text/plain, Size: 3837 bytes --]

On Wed, 2021-03-10 at 18:28 +0000, Luca Boccassi wrote:
> On Tue, 2021-03-09 at 23:43 +0000, Richard Purdie wrote:
> > On Tue, 2021-03-09 at 13:56 +0000, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > >
> > > Recently util-linux gained an (optional) build dependency on libcryptsetup.
> > > But libcryptsetup build-depends on util-linux for blkid (optional, can be disabled)
> > > and uuid (mandatory).
> > > Split out util-linux-uuid in a different recipe to break the cycle.
> > >
> > > https://github.com/karelzak/util-linux/pull/898
> > >
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > ---
> > > v1: util-linux 2.35 is not out yet, but I'd like to get the preparatory work
> > > underway as I'm not sure if this is the best approach or if there are
> > > alternatives. Suggestions and comments very welcome. Thanks!
> > > v2: changed packages names to reflect old ones (eg: libuuid1 -> util-linux-libuuid)
> > > and leave uuid build enable in main recipe to allow for uuidgen build to happen,
> > > as it does not have its own autoconf switch. Delete the library manualy from
> > > the main recipe after build instead, and add dependency.
> > > Might help to break loop python3 -> util-linux -> libselinux -> python3, as it's
> > > only libuuid that is needed, see https://lists.yoctoproject.org/g/yocto/message/47570
> > > v3: rebased and refactored to have a common util-linux.inc file
> > > v4: added RDEPENDS on util-linux-libuuid on various packages to fix QA warnings
> > > v5: remove RDEPENDS and instead have util-linux RDEPEND on util-linux-uuid.
> > > Removed PACKAGES_remove and instead filter out libuuid via the package generation
> > > regex.
> > > Rebased on util-linux 2.36.2.
> > > v6: install libuuid.a in libuuid-dev
> > > change rdepends on uuid to use binary package rather than source
> > > add rdepends on uuid-dev to libuuid-dev
> > > remove rprovides of libuuid-dev from uuid-dev
> > > v7: do not use '_append' for RDEPENDS, as it is not supported by BBCLASSEXTEND, use
> > > simply '+='
> > > v8: added missing libuuid-staticdev package
> > > remove libx32/libuuid* too
> > > v9: set RECIPE_MAINTAINER_pn-util-linux-uuid, same value as RECIPE_MAINTAINER_pn-util-linux
> >
> > Sorry, there are still issues:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/3207
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/1608
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/3159
> >
> > :(
> >
> > I really want to get this into the release but we're past feature freeze and
> > running out of opportunity as each broken test run is delaying other patches.
>
> No problem at all, it's absolutely fine to postpone, I am in no
> immediate rush as I have local backports in use. As long as we get
> things sorted at some point it's all good for me, so please don't delay
> other patches because of this.
>
> > I'm a little unclear if debian renaming was allowed before the split and if
> > so, why it is disabled in the split version. I suspect there is a missing
> > MLPREFIX somewhere causing the multilib issue too.
>
> I do not remember why the DEBIAN_NOAUTONAME was added at this point.
> I'll try to send a new version tomorrow.

So without DEBIAN_NOAUTONAME these are the package names:

libuuid1-2.36.2-r0.core2_64.rpm
libuuid-dbg-2.36.2-r0.core2_64.rpm
libuuid-dev-2.36.2-r0.core2_64.rpm
util-linux-uuid-src-2.36.2-r0.core2_64.rpm

that's going to be a problem as they don't match anymore, right? Since
they used to be util-linux-libuuid, etc. Although the poky image build
completed just fine...

--
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 499 bytes --]