public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Böszörményi Zoltán" <zboszor@gmail.com>
To: f_l_k@t-online.de, Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][oe-core][PATCH] mesa: add support for rusticl
Date: Fri, 13 Sep 2024 12:40:26 +0200	[thread overview]
Message-ID: <686f2e31-0311-4e02-b688-9cdd95bc71c3@gmail.com> (raw)
In-Reply-To: <HSHJJS.OO3X80OW2KGA@t-online.de>

2024. 09. 09. 11:45 keltezéssel, Markus Volk via lists.openembedded.org írta:
> On Mon, Sep 9 2024 at 10:46:59 AM +02:00:00, Alexander Kanavin <alex.kanavin@gmail.com> 
> wrote:
>> This does need to be properly looked into, there's probably a better patch possible, or 
>> a build setting we're missing, or at least an upstream ticket to be filed. It's not a 
>> good patch when it says 'workaround' and doesn't explain the issue and the fix.
>
> Fully agree. This is ugly as hell. Just a quick and dirty hack to get things working 
> (which is always a good starting point) but by no means a solution for oe-core. Thats 
> why I marked it RFC

Don't call it a "workaround" then.
Call it "pass in recipe-sysroot include directories" because
that's what this patch does combined with the mesa.inc changes.

Though it's not complete in my testing.
I needed this patch against 24.2.2 so I could build Mesa Rusticl,
plus EXTRA_OEMESON += "-Dintel-rt=disabled" in my bbappend
because the iris driver failed to build otherwise, complaining for
every generated file from *.cl about "shader not available, consider
installing libclc" or something like that, eventually failing the build.

diff --git a/src/gallium/frontends/rusticl/meson.build 
b/src/gallium/frontends/rusticl/meson.build
index eef09d8f01e..efac4cab964 100644
--- a/src/gallium/frontends/rusticl/meson.build
+++ b/src/gallium/frontends/rusticl/meson.build
@@ -146,6 +146,7 @@ rusticl_opencl_bindings_rs = rust.bindgen(
      rusticl_bindgen_c_args,
      pre_args,
      cl_c_args,
+   '-I@include@', '-I@include_cpp@', '-I@include_cpp_target_sys@'
    ],
    args : [
      rusticl_bindgen_args,
@@ -190,6 +191,7 @@ rusticl_llvm_bindings_rs = rust.bindgen(
    c_args : [
      rusticl_bindgen_c_args,
      pre_args,
+   '-I@include@', '-I@include_cpp@', '-I@include_cpp_target_sys@'
    ],
    dependencies : [
      dep_clang,


>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#204323): https://lists.openembedded.org/g/openembedded-core/message/204323
> Mute This Topic: https://lists.openembedded.org/mt/108340502/3617728
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [zboszor@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>



  reply	other threads:[~2024-09-13 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08 17:23 [RFC][oe-core][PATCH] mesa: add support for rusticl Markus Volk
2024-09-08 17:33 ` Patchtest results for " patchtest
2024-09-09  8:46 ` Alexander Kanavin
2024-09-09  9:45   ` Markus Volk
2024-09-13 10:40     ` Böszörményi Zoltán [this message]
     [not found]     ` <17F4C79C2431BD42.10184@lists.openembedded.org>
2024-09-13 10:43       ` Böszörményi Zoltán
2024-09-13 12:59         ` Markus Volk
2024-09-13 13:20           ` Böszörményi Zoltán

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=686f2e31-0311-4e02-b688-9cdd95bc71c3@gmail.com \
    --to=zboszor@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=f_l_k@t-online.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox