Openembedded Core Discussions
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] netbase/base-files: move /etc/hosts from netbase to base-files
Date: Tue, 08 Jan 2019 12:47:09 +0000	[thread overview]
Message-ID: <6af27248c02eb709ad45c6cbfbe7e464b80cd2db.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJTo0Lbj10QLG-AH6YYOua1NtZfcPGKi0swnKR444bPjBrJZEQ@mail.gmail.com>

On Tue, 2019-01-08 at 12:45 +0000, Burton, Ross wrote:
> On Tue, 8 Jan 2019 at 12:45, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Tue, 2019-01-08 at 12:40 +0000, Burton, Ross wrote:
> > > On Tue, 8 Jan 2019 at 09:06, Chen Qi <Qi.Chen@windriver.com>
> > > wrote:
> > > >         if [ "${hostname}" ]; then
> > > >                 echo ${hostname} > ${D}${sysconfdir}/hostname
> > > > +               echo "127.0.1.1 ${hostname}" >>
> > > > ${D}${sysconfdir}/hosts
> > > >         fi
> > > 
> > > Instead of appending to the file, can you put a marker on the
> > > 127.0.0.1 line and replace it inline?
> > 
> > Not so good if hostname isn't set?
> 
> hostname = "${MACHINE}"
> 
> Hostname is always set. :)

Its the kind of thing people likely bbappend and change, or set from
overrides. Which was one of the reasons I'm nervous about moving hosts
to a different package in the first place...

Cheers,

RIchard



  reply	other threads:[~2019-01-08 12:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  9:12 [PATCH 0/1] netbase/base-files: move /etc/hosts from netbase to base-files Chen Qi
2019-01-08  9:12 ` [PATCH 1/1] " Chen Qi
2019-01-08 12:40   ` Burton, Ross
2019-01-08 12:44     ` Richard Purdie
2019-01-08 12:45       ` Burton, Ross
2019-01-08 12:47         ` richard.purdie [this message]
2019-01-08 13:00           ` Burton, Ross
2019-01-09  1:47             ` ChenQi
2019-01-09 11:34   ` Peter Kjellerstedt
2019-01-08  9:33 ` ✗ patchtest: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6af27248c02eb709ad45c6cbfbe7e464b80cd2db.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox