From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Amarnath Valluri <amarnath.valluri@intel.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3 2/8] cross.bbclass: merged /usr support
Date: Tue, 13 Jun 2017 07:52:15 +0000 [thread overview]
Message-ID: <6c245347ca324b9ea7b88bcaf920e35f@XBOX02.axis.com> (raw)
In-Reply-To: <1497336760-36835-3-git-send-email-amarnath.valluri@intel.com>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Amarnath Valluri
> Sent: den 13 juni 2017 08:53
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH v3 2/8] cross.bbclass: merged /usr support
>
> To be align with base configuration change, use ${root_prefix} while
> preparing
> ${target_base_libdir}.
>
> Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
> ---
> meta/classes/cross.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/cross.bbclass b/meta/classes/cross.bbclass
> index 8757303..7720185 100644
> --- a/meta/classes/cross.bbclass
> +++ b/meta/classes/cross.bbclass
> @@ -50,10 +50,10 @@ SSTATE_SCAN_CMD ?= "${SSTATE_SCAN_CMD_NATIVE}"
> # Path mangling needed by the cross packaging
> # Note that we use := here to ensure that libdir and includedir are
> # target paths.
> -target_base_prefix := "${base_prefix}"
> +target_root_prefix := "${root_prefix}"
It is probably better to do:
target_base_prefix := "${root_prefix}"
I.e., maintain the target_base_prefix variable, in case it is used
in some external layer.
> target_prefix := "${prefix}"
> target_exec_prefix := "${exec_prefix}"
> -target_base_libdir = "${target_base_prefix}/${baselib}"
> +target_base_libdir = "${target_root_prefix}/${baselib}"
> target_libdir = "${target_exec_prefix}/${baselib}"
> target_includedir := "${includedir}"
>
> --
> 2.7.4
//Peter
next prev parent reply other threads:[~2017-06-13 7:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 6:52 [PATCH v3 0/8] Fix for #7040 - Support for /usr merge Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 1/8] bitbake.conf: support for merged usr with DISTRO_FEATURE usrmerge Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 2/8] cross.bbclass: merged /usr support Amarnath Valluri
2017-06-13 7:52 ` Peter Kjellerstedt [this message]
2017-06-13 13:27 ` [PATCH v4 " Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 3/8] systemd: chagnes to support merged /usr Amarnath Valluri
2017-06-13 7:56 ` Peter Kjellerstedt
2017-06-13 13:26 ` [PATCH v4 3/8] systemd: changes " Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 4/8] bash: " Amarnath Valluri
2017-06-15 9:50 ` Anton Eliasson
2017-06-13 6:52 ` [PATCH v3 5/8] busybox: " Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 6/8] sed: " Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 7/8] image: create symlinks needed for " Amarnath Valluri
2017-06-13 8:05 ` Peter Kjellerstedt
2017-06-13 12:32 ` Valluri, Amarnath
2017-06-13 13:23 ` [PATCH v4 " Amarnath Valluri
2017-06-13 14:16 ` Peter Kjellerstedt
2017-06-13 19:25 ` Amarnath Valluri
2017-06-13 6:52 ` [PATCH v3 8/8] insane.bbclass: Add package QA check " Amarnath Valluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c245347ca324b9ea7b88bcaf920e35f@XBOX02.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=amarnath.valluri@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox