Re: [OE-core] [PATCH v3] Add new recipe for squashfs-tools-ng

Richard Purdie
2020-10-24T12:58:53Z

On Thu, 2020-10-22 at 12:30 +0100, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
> recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
>
> .../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
>
> diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> new file mode 100644
> index 0000000000..293b31cd92
> --- /dev/null
> +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "New set of tools for working with SquashFS images"
> +SECTION = "base"
> +LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
> +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> +
> +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
> +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"

Testing on the autobuilder showed up:

ERROR: Nothing PROVIDES 'zstd' (but /home/pokybuild/yocto-worker/check-layer/build/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb DEPENDS on or otherwise requires it)

(zstd isn't in OE-Core)

Cheers,

Richard