Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng

Luca Bocassi
2020-10-22T09:21:36Z

On Wed, 2020-10-21 at 21:08 +0200, Konrad Weihmann wrote:
> On 21.10.20 17:58, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> >
> > diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > new file mode 100644
> > index 0000000000..bbc5f86ae9
> > --- /dev/null
> > +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > @@ -0,0 +1,37 @@
> > +SUMMARY = "New set of tools for working with SquashFS images"
> > +SECTION = "base"
> > +LICENSE = "GPLv3+ & LGPL-3.0+"
>
> A bit of nitpick, but with all the license files mentioned below the
> LICENSE setting looks wrong to me.
> I would at least expect some BSD and zLib SPDX identifiers here.

Added MIT, Zlib and BSD-2-Clause in v2.

> To be super exact one would have to take the PACKAGECONFIG into account
> to get the correct value

The binary is distributed under the terms of GPL3 regardless, so not
sure it's worth the complications? Is it required/commonly done in
other recipes?

--
Kind regards,
Luca Boccassi