From: Olaf Mandel <o.mandel@menlosystems.com>
To: Dan McGregor <danismostlikely@gmail.com>
Cc: marex@denx.de,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] npm: change install directory to upstream default
Date: Mon, 29 Oct 2018 11:39:55 +0100 [thread overview]
Message-ID: <6d4e8838-01fc-1452-0676-e6657b428fca@menlosystems.com> (raw)
In-Reply-To: <CACS+7ZTTdXs4WuMqBede2KPrsxWu-By1CvZ8t8SvLzRUU-Z6RA@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hello Dan,
Am 26.10.2018 um 19:46 schrieb Dan McGregor:
> On Fri, 19 Oct 2018 at 09:29, Olaf Mandel
> <o.mandel@menlosystems.com> wrote:
>> -NPM_INSTALLDIR = "${D}${libdir}/node_modules/${NPMPN}"
>> +NPM_INSTALLDIR = "${D}${libdir}/node/${NPMPN}"
>
> Ï realise this has already gone în, but should this be
> ${nonarch_libdir}, or does it use /usr/lib64 or /usr/libx32
> correctly?
>
For me, libdir resolves to /usr/lib, so I didn't notice any problems.
And the "lib"-part is hardcoded in NodeJS (lib/module.js:
path.resolve(prefixDir, 'lib', 'node')).
So if ${nonarch_libdir} is always ${prefix}/lib even if ${libdir}
isn't, then that should be changed.
Best regards,
Olaf Mandel
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEErGOsr28GGMKRE/TmVL2dtGJSHf8FAlvW43UACgkQVL2dtGJS
Hf8gLAf/aIQ5z219f1Tqtp5Oc1mBr4IN3T/Uzk6MlKKtqfQGS2KBF7CqWLUKNXT2
/eKa/v7H55yTWC6PSlJjx7HMzJK9mhwZ84LwAQ4rpj6ZBn1RYjv4DBdgPxlQN+1N
4kAoWklpgBut0eNtb9hniwf2VhF7rkI8eLVdNcL1SR7JroDahSnjVGozuE/asxK0
yJHHaz3cbe6QooYKeyi4y6lM1wJfP5Wny0rOCMh3rWvsexf7G7itki0MoRU7dNVv
C2zK+/KVjhYbLWSRijSYjGRFpMzKb9AddBxkpIZ4z7vjAlbbbYN1iw3RdPoiPYhP
rwvtSk3Wwe4McsVUjRaEFxwcdCPQQQ==
=1BcQ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2018-10-29 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 15:22 [PATCH] npm: change install directory to upstream default Olaf Mandel
2018-10-19 16:53 ` Marek Vasut
2018-10-22 9:50 ` [PATCH v2] " Olaf Mandel
2018-10-22 10:10 ` [PATCH v3] " Olaf Mandel
2018-10-22 10:03 ` ✗ patchtest: failure for npm: change install directory to upstream default (rev2) Patchwork
2018-10-22 10:33 ` ✗ patchtest: failure for npm: change install directory to upstream default (rev3) Patchwork
2018-10-22 10:45 ` Olaf Mandel
2018-10-22 22:45 ` Richard Purdie
2018-10-23 10:30 ` Olaf Mandel
2018-10-26 17:46 ` [PATCH] npm: change install directory to upstream default Dan McGregor
2018-10-29 10:39 ` Olaf Mandel [this message]
2018-10-31 16:38 ` Dan McGregor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4e8838-01fc-1452-0676-e6657b428fca@menlosystems.com \
--to=o.mandel@menlosystems.com \
--cc=danismostlikely@gmail.com \
--cc=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox