Re: [PATCH] squashfs-tools: upgrade to commit f95864afe883

["Ulrich Ölmann" <u.oelmann@pengutronix.de>]

On Thu, Jul 18 2019 at 08:19 +0200, Adrian Bunk <bunk@stusta.de> wrote:
> On Wed, Jul 17, 2019 at 11:57:42AM +0100, richard.purdie@linuxfoundation.org wrote:
>> On Wed, 2019-07-17 at 12:51 +0200, Ulrich Ölmann wrote:
>> > Hi Richard,
>> > 
>> > On Wed, Jul 17 2019 at 11:19 +0200, Richard Purdie <
>> > richard.purdie@linuxfoundation.org> wrote:
>> > > On Tue, 2019-07-16 at 15:54 +0200, Ulrich Ölmann wrote:  
>> > > > [...] 
>> > > > -PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr"
>> > > > +PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr zstd reproducible"
>> > > > [...] 
>> > > > +PACKAGECONFIG[zstd] = "ZSTD_SUPPORT=1,ZSTD_SUPPORT=0,zstd"
>> > > > +PACKAGECONFIG[reproducible] =
>> > > > "REPRODUCIBLE_DEFAULT=1,REPRODUCIBLE_DEFAULT=0,"
>> > > 
>> > > This fails in OE-Core since zstd isn't present and you've enabled
>> > > that
>> > > by default:
>> > > 
>> > > e.g.:
>> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/827
>> > > 
>> > > (but many other similar failures).
>> > > 
>> > > Adding the PACKAGECONFIG[zstd] is good, we just can't enable it by
>> > > default.
>> > 
>> > see my reply to Adrian: what do you think of transplanting the zstd
>> > recipe from meta-rauc to OE-core?
>> 
>> I think right now that zstd is not common enough to be something for
>> oe-core. If multiple people reply and disagree I'm willing to reasses
>> that but that's my feeling right now...
>
> zstd not even being in meta-oe is a surprise that should be corrected.
>
> btrfs-tools would be the only user that comes immediately into my mind,
> but zstd support in the kernel btrfs driver is relatively new and not
> yet widely used.
>
> zstd has already gotten a lot of traction in the Open Source world,
> but regarding adding it to oe-core right now one could argue either way.

Nobody stood up and objected in the last 24h, so I will send a v2 that
simply drops "zstd" from the set of default options and refers to
meta-rauc's recipe.

>> Cheers,
>> 
>> Richard
>
> cu
> Adrian

Best regards
Ulrich
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |