Re: [PATCH V2 2/4] dpkg: modify the run-postinst script to enable postinst logging

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Monday 20 May 2013 10:50:29 Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> Enable postinst logging by checking the configuration in /etc/
> default/postinst.
> 
> In this way, the postinst logging is enabled if 'debug-tweaks' is
> in IMAGE_FEATURES, and at the same time, we avoid unnecessary rebuilt
> if IMAGE_FEATURES is changed.
> 
> [YOCTO #4262]
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/recipes-devtools/dpkg/dpkg.inc |   11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-devtools/dpkg/dpkg.inc
> b/meta/recipes-devtools/dpkg/dpkg.inc index d773fbd..c5c8aec 100644
> --- a/meta/recipes-devtools/dpkg/dpkg.inc
> +++ b/meta/recipes-devtools/dpkg/dpkg.inc
> @@ -35,10 +35,6 @@ do_configure () {
>      autotools_do_configure
>  }
> 
> -POSTLOG ?= "/var/log/postinstall.log"
> -REDIRECT_CMD = "${@base_contains('IMAGE_FEATURES', 'debug-tweaks',
> '>${POSTLOG} 2>&1', '', d)}" -REDIRECT_CMD[vardepsexclude] +=
> "IMAGE_FEATURES POSTLOG"
> -
>  DPKG_INIT_POSITION ?= "98"
> 
>  do_install_append () {
> @@ -67,7 +63,12 @@ if [ "x$D" != "x" ] && [ -f $D/var/lib/dpkg/status ];
> then
> 
>  	# this happens at S98 where our good 'ole packages script used to run
>  	echo "#!/bin/sh
> -dpkg --configure -a ${REDIRECT_CMD}
> +[ -e /etc/default/postinst ] && . /etc/default/postinst
> +if [ \"\$POSTINST_LOGGING\" = \"ENABLED\" ]; then

Can we use 1 for this instead of ENABLED? This would be more consistent with 
how variables such as this are generally used.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre