Re: [PATCH 1/3] acl: Make it compatible with externalsrc

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2018-09-24 at 21:03 +0200, Peter Kjellerstedt wrote:
> Make the subdir fetch path for configure.ac relative. This avoids the
> following error after having done `devtool modify acl`:
> 
> ERROR: acl-2.2.52-r0 do_unpack: Unpack failure for URL:
> 'file://configure.ac;subdir=.../builds/qemux86-
> 64/workspace/sources/acl'.
> subdir argument isn't a subdirectory of unpack root
> .../builds/qemux86-64/tmp/work/core2-64-poky-linux/acl/2.2.52-r0
> 
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>  meta/recipes-support/attr/acl_2.2.52.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/attr/acl_2.2.52.bb b/meta/recipes-
> support/attr/acl_2.2.52.bb
> index 8f3dc45cf7..8b89de9b42 100644
> --- a/meta/recipes-support/attr/acl_2.2.52.bb
> +++ b/meta/recipes-support/attr/acl_2.2.52.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=c781d70e
> d2b4d48995b790403217a249 \
>  DEPENDS = "attr"
>  
>  SRC_URI = "${SAVANNAH_GNU_MIRROR}/acl/${BP}.src.tar.gz \
> -           file://configure.ac;subdir=${S} \
> +           file://configure.ac;subdir=${BP} \
>             file://run-ptest \
>             file://acl-fix-the-order-of-expected-output-of-
> getfacl.patch \
>             file://test-fix-insufficient-quoting-of.patch \

This isn't making sense to me. Doesn't externalsrc set ${S} to the
external source location?

Also, doesn't it remove the do_unpack task?

Cheers,

Richard