From: Clayton Casciato <majortomtosourcecontrol@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: randy.macleod@windriver.com, yoann.congal@smile.fr
Subject: Re: [PATCH] uboot-sign: fix concat_dtb arguments
Date: Thu, 14 Nov 2024 06:35:29 -0700 [thread overview]
Message-ID: <72af1bc8-f20a-4fc8-926a-1418580f303d@gmail.com> (raw)
In-Reply-To: <b676cb1d-53f0-403d-969f-e0bfdaedc4cc@gmail.com>
Hello!
I am looking for feedback and/or the status for this patch.
Thanks!
--
Clayton Casciato
On 11/7/24 10:10 AM, Clayton Casciato wrote:
> Fixes [YOCTO #15642]
>
> Ensure empty argument passed from do_uboot_assemble_fitimage is passed to
> concat_dtb
>
> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> ---
> Sponsor: 21SoftWare LLC
>
> meta/classes-recipe/uboot-sign.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/uboot-sign.bbclass b/meta/classes-recipe/uboot-sign.bbclass
> index 3e5f5dcf66..a17be745ce 100644
> --- a/meta/classes-recipe/uboot-sign.bbclass
> +++ b/meta/classes-recipe/uboot-sign.bbclass
> @@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
> binary="$2"
>
> if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
> - concat_dtb $type $binary
> + concat_dtb "$type" "$binary"
> fi
>
> if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then
next prev parent reply other threads:[~2024-11-14 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 17:10 [PATCH] uboot-sign: fix concat_dtb arguments Clayton Casciato
2024-11-14 13:35 ` Clayton Casciato [this message]
2024-11-14 14:35 ` [OE-core] " Mathieu Dubois-Briand
2024-11-14 14:49 ` Clayton Casciato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72af1bc8-f20a-4fc8-926a-1418580f303d@gmail.com \
--to=majortomtosourcecontrol@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.macleod@windriver.com \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox