Re: [OE-core] [PATCH] qemurunner.py: print output from runqemu/qemu-system in stop()

Alexander Kanavin
2021-08-26T10:45:28Z

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

It’s not a real warning, just that the print itself is issued as a warning.
I think it just needs to be issued as info instead.

Alex

On Thu 26. Aug 2021 at 11.42, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Thu, 2021-08-26 at 00:35 +0200, Alexander Kanavin wrote:
> > This is done when starting up qemu has failed, but is not done
> > when qemu started ok, but fails later in QMP communication.
> >
> > Output from runqemu does contain valuable information to find out
> > why, so rather than fix all the QMP fails to include it, let's just
> > print it in stop().
> >
> > Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> > ---
> > meta/lib/oeqa/utils/qemurunner.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/lib/oeqa/utils/qemurunner.py
> b/meta/lib/oeqa/utils/qemurunner.py
> > index 5c9d2b24a3..e099c6e2a7 100644
> > --- a/meta/lib/oeqa/utils/qemurunner.py
> > +++ b/meta/lib/oeqa/utils/qemurunner.py
> > @@ -535,6 +535,8 @@ class QemuRunner:
> > if self.runqemu.poll() is None:
> > self.logger.debug("Sending SIGKILL to runqemu")
> > os.killpg(os.getpgid(self.runqemu.pid), signal.SIGKILL)
> > + if not self.runqemu.stdout.closed:
> > + self.logger.warning("Output from runqemu:\n%s" %
> self.getOutput(self.runqemu.stdout))
> > self.runqemu.stdin.close()
> > self.runqemu.stdout.close()
> > self.runqemu_exited = True
>
> I like the idea of this but it is showing warnings on the autobuilder:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3877
>
> So we may need to fix the issue it is exposing?
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 2582 bytes --]