From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][kirkstone 13/26] devtool/upgrade: catch bb.fetch2.decodeurl errors
Date: Thu, 18 Aug 2022 16:42:35 -1000 [thread overview]
Message-ID: <72bfdca08029c031cedc9dbbf366663632c1c8db.1660876844.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1660876844.git.steve@sakoman.com>
From: Alexander Kanavin <alex.kanavin@gmail.com>
Otherwise, workspace cleanup (removing bogus recipe and source tree)
will not happen, leaving breakage behind.
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
(cherry picked from commit 74774f9b67580a8c56f605dfd4cc7b856bbeeae8)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
scripts/lib/devtool/upgrade.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py
index c57015eb40..39a1910a49 100644
--- a/scripts/lib/devtool/upgrade.py
+++ b/scripts/lib/devtool/upgrade.py
@@ -336,7 +336,10 @@ def _create_new_recipe(newpv, md5, sha256, srcrev, srcbranch, srcsubdir_old, src
replacing = True
new_src_uri = []
for entry in src_uri:
- scheme, network, path, user, passwd, params = bb.fetch2.decodeurl(entry)
+ try:
+ scheme, network, path, user, passwd, params = bb.fetch2.decodeurl(entry)
+ except bb.fetch2.MalformedUrl as e:
+ raise DevtoolError("Could not decode SRC_URI: {}".format(e))
if replacing and scheme in ['git', 'gitsm']:
branch = params.get('branch', 'master')
if rd.expand(branch) != srcbranch:
--
2.25.1
next prev parent reply other threads:[~2022-08-19 2:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 2:42 [OE-core][kirkstone 00/26] Patch review Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 01/26] gdk-pixbuf: CVE-2021-46829 a heap-based buffer overflow Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 02/26] qemu: fix CVE-2021-3507 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 03/26] qemu: fix CVE-2021-3929 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 04/26] qemu: fix CVE-2021-4158 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 05/26] qemu: fix CVE-2022-0358 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 06/26] qemu: fix CVE-2022-0216 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 07/26] u-boot: fix CVE-2022-33103 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 08/26] gnutls: CVE-2022-2509 Double free during gnutls_pkcs7_verify Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 09/26] zlib: CVE-2022-37434 a heap-based buffer over-read Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 10/26] vim: update from 9.0.0063 to 9.0.0115 Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 11/26] devtool: error out when workspace is using old override syntax Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 12/26] devtool/upgrade: correctly clean up when recipe filename isn't yet known Steve Sakoman
2022-08-19 2:42 ` Steve Sakoman [this message]
2022-08-19 2:42 ` [OE-core][kirkstone 14/26] runqemu: Add missing space on default display option Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 15/26] archiver.bbclass: remove unsed do_deploy_archives[dirs] Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 16/26] create-spdx: Fix supplier field Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 17/26] create-spdx: ignore packing control files from ipk and deb Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 18/26] boost: fix install of fiber shared libraries Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 19/26] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 20/26] scripts/oe-setup-builddir: make it known where configurations come from Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 21/26] nativesdk: Clear TUNE_FEATURES Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 22/26] relocate_sdk.py: ensure interpreter size error causes relocation to fail Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 23/26] selftest/wic: Tweak test case to not depend on kernel size Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 24/26] lttng-modules: fix 5.19+ build Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 25/26] lttng-modules: fix build against mips and v5.19 kernel Steve Sakoman
2022-08-19 2:42 ` [OE-core][kirkstone 26/26] lttng-modules: replace mips compaction fix with upstream change Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72bfdca08029c031cedc9dbbf366663632c1c8db.1660876844.git.steve@sakoman.com \
--to=steve@sakoman.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox