Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] strace: add configure options libaio and acl
Date: Mon, 01 Jul 2013 10:45:12 +0100	[thread overview]
Message-ID: <7382678.nsfBjGc6RQ@helios> (raw)
In-Reply-To: <51D0E0EA.5040902@windriver.com>

On Monday 01 July 2013 09:52:42 Kang Kai wrote:
> On 2013年06月29日 01:16, Paul Eggleton wrote:
> > Secondly, although this seems to work the use
> > of overrides, += and ?= together is a little bit confusing. Perhaps the
> > following would be a bit clearer:
> > 
> > PACKAGECONFIG_class-target ?= "aio \
> > 
> >                                ${@base_contains('DISTRO_FEATURES', 'acl',
> >                                'acl', '', d)}"
> 
> I considered this way.
> When 'acl' in distro feature, I want strace enable acl support. But
> PACKAGECONFIG could be overwritten that even 'acl' in distro feature but
> not in 'PACKAGECONFIG'.

I don't think this is a big issue - we have a fairly strong precedent for 
doing it this way so that PACKAGECONFIG customisation overrides 
DISTRO_FEATURES, based on usage in other recipes.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


      reply	other threads:[~2013-07-01  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  8:12 [PATCH 0/2] V3: Update strace to 4.8 Kai Kang
2013-06-21  8:12 ` [PATCH 1/2] strace: update " Kai Kang
2013-06-21 12:25   ` Richard Purdie
2013-06-21  8:12 ` [PATCH 2/2] strace: add configure options libaio and acl Kai Kang
2013-06-28 17:16   ` Paul Eggleton
2013-07-01  1:52     ` Kang Kai
2013-07-01  9:45       ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7382678.nsfBjGc6RQ@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=Kai.Kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox