Re: [OE-core][PATCH] lttng-tools: skip lttng kernel related test if lttng kernel modules not present

[Xiangyu Chen <xiangyu.chen@eng.windriver.com>]

On 2/10/24 00:44, Richard Purdie wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Wed, 2024-01-31 at 11:40 +0800, Xiangyu Chen wrote:
>> From: Xiangyu Chen <xiangyu.chen@windriver.com>
>>
>> The current tests will run both userspace and kernel testing. Some of use cases only
>> use lttng for one kind of tracing (e.g. userspace). If the lttng modules(.ko files)
>> is not present during the test,it would end up with lots of failing.
>>
>> Add a check in ptest script, if current system doesn't contain lttng kernel modules,
>> passing LTTNG_TOOLS_DISABLE_KERNEL_TESTS=1 to make to skip all lttng kernel related testing.
>>
>> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
>> ---
>>   ...skip_kernel_test-to-check-root-user-.patch | 1307 +++++++++++++++++
>>   .../lttng/lttng-tools/run-ptest               |   25 +
>>   .../lttng/lttng-tools_2.13.11.bb              |    1 +
>>   3 files changed, 1333 insertions(+)
>>   create mode 100644 meta/recipes-kernel/lttng/lttng-tools/0001-tests-add-check_skip_kernel_test-to-check-root-user-.patch
> This is a complex patch and I don't really want to carry this until
> something merges upstream or ideally makes it into a released version.

Hi Richard,


Thanks for your suggestion,

lttng upstream has merged this patch, I'll send a v2 patch to oe-core 
later after a simple testing in my local setup.


Br,

Xiangyu

>
> We simply don't have the maintainer capacity to carry large patches
> like this unfortunately and the number of people who need it isn't
> clear.
>
> Cheers,
>
> Richard