Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] security_flags.inc: add var-FSTACK_PROTECTOR to improve variable OVERRIDES
Date: Wed, 29 Aug 2018 17:21:11 +0800	[thread overview]
Message-ID: <7519fb76-4424-9904-e87a-8dc1dc5746e3@windriver.com> (raw)
In-Reply-To: <dcef97cf1a06461aabe990674fd25bd9@XBOX02.axis.com>

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On 2018年08月29日 17:18, Peter Kjellerstedt wrote:
>> -SECURITY_CFLAGS ?= "-fstack-protector-strong ${SECURITY_PIE_CFLAGS} ${lcl_maybe_fortify} ${SECURITY_STRINGFORMAT}"
>> -SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-strong ${lcl_maybe_fortify} ${SECURITY_STRINGFORMAT}"
>> +FSTACK_PROTECTOR ?= "-fstack-protector-strong"
> May I suggest to call it SECURITY_STACK_PROTECTOR instead? That aligns
> it better with the other variables.
>
I am no objection on it, after collection the reply, I

will send V2 to tweak it

//Hongxu


[-- Attachment #2: Type: text/html, Size: 1049 bytes --]

  reply	other threads:[~2018-08-29  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  9:04 [PATCH 1/2] security_flags.inc: use `?=' to set a default var-lcl_maybe_fortify Hongxu Jia
2018-08-29  9:04 ` [PATCH 2/2] security_flags.inc: add var-FSTACK_PROTECTOR to improve variable OVERRIDES Hongxu Jia
2018-08-29  9:18   ` Peter Kjellerstedt
2018-08-29  9:21     ` Hongxu Jia [this message]
2018-08-29 14:01   ` [PATCH V2] security_flags.inc: add var-SECURITY_STACK_PROTECTOR " Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7519fb76-4424-9904-e87a-8dc1dc5746e3@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox