Re: [PATCH] devtool: build: add deploy to the tasks run for devtool build

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2019-06-07 at 15:17 -0700, Jaewon Lee wrote:
> Right now `devtool build` runs populate_sysroot and packagedata
> tasks.
> Adding deploy to this list so that the newly built artifacts are
> available in the deploy directory.
> 
> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
> 
> [YOCTO #13382]
> 
> Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
> ---
>  scripts/lib/devtool/build.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/devtool/build.py
> b/scripts/lib/devtool/build.py
> index 7543398..aff5710 100644
> --- a/scripts/lib/devtool/build.py
> +++ b/scripts/lib/devtool/build.py
> @@ -37,7 +37,7 @@ def _set_file_values(fn, values):
>      return updated
>  
>  def _get_build_tasks(config):
> -    tasks = config.get('Build', 'build_task',
> 'populate_sysroot,packagedata').split(',')
> +    tasks = config.get('Build', 'build_task',
> 'deploy,populate_sysroot,packagedata').split(',')
>      return ['do_%s' % task.strip() for task in tasks]
>  
>  def build(args, config, basepath, workspace):

This frustrates me a bit.

The key question you have to ask here is "What happens for recipes that
don't have a do_deploy task?".

The answer is it breaks:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/506

*Please*, when sending devtool patches, test with:

oe-selftest -r devtool

Cheers,

Richard