From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by mx.groups.io with SMTP id smtpd.web11.735.1607019205821727227 for ; Thu, 03 Dec 2020 10:13:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=DY4aKqod; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.214.195, mailfrom: scott.branden@broadcom.com) Received: by mail-pl1-f195.google.com with SMTP id bj5so1603073plb.4 for ; Thu, 03 Dec 2020 10:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to; bh=+gtZjjKY6HS/gzDEUtNTQx8a2aqpOFAwMeP6jxUk52M=; b=DY4aKqodiK1z0HrpK0kwkVWr0IT53uMD7LEtvGz0iDRKBUoTljykiOZuTIV/SYa4Ny Z94gNAnjz8o9EVgyxalLlXeq+UAZIiZZGdemc5j7Bc73BDxYcaD4MMGmg+54tggD5QP8 tgXmlew/k3Ho+7AE3EszNGrzcUZ7TUMGWHaGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=+gtZjjKY6HS/gzDEUtNTQx8a2aqpOFAwMeP6jxUk52M=; b=FHJmEPPmRrVOrIn2PS5yJe67kZszfTV0BPOjgPcazXGjrZA7qV2eXMRYnjV6RlGOqH 6YQ8qKc1zkPaGfSkABIuQXkdsfkcI9OD+znDEC1nxOLynJGH9ZGPRjge7wODw1MrImxV okDkedP+8Yf6a/kSuPdCG+CARQ0YtxTgaoEH2bl2E8ekOUDDIGrlAV13KlbLJ5QIrf5a 21kP1y+SLgXYDjZUiUV/fISq7sHSqi9uvv5tXDNVRctp5ObryVp/NctTOdf/Dqqzbqi+ oKWkbRvHrxcsuWmakU5B37E6bFG4d48EV/Qln5U6EFSxazEjg6SRE9zNvMfRhLFXOmte KCJw== X-Gm-Message-State: AOAM530RtVsv6VBOJ7qYtWOcurG6VUriZ5hGOhf/2do4n4asj/hTw7KT pv2xp2zfkofiS9UtY6erxzYfPg== X-Google-Smtp-Source: ABdhPJwCbdheNAJ8atYjXsrUfl43hrSOKAjrQl3rfLY4iU5x8pvUQbfABiR4xlZMAbMo6zdHvkJRhA== X-Received: by 2002:a17:90a:7c44:: with SMTP id e4mr333821pjl.138.1607019205191; Thu, 03 Dec 2020 10:13:25 -0800 (PST) Return-Path: Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id y188sm2448750pfy.98.2020.12.03.10.13.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 10:13:24 -0800 (PST) Subject: Re: commit breaks menuconfig on upstream kernel "cml1.bbclass: Handle ncurses-native being available via pkg-config" To: Nathan Rossi Cc: OE-core , Richard Purdie References: From: "Scott Branden" Message-ID: <764b6894-3e48-ee19-ff58-7b3a1cd6930a@broadcom.com> Date: Thu, 3 Dec 2020 10:13:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Groupsio-MsgNum: 145244 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000e5eb4d05b59350fc" --000000000000e5eb4d05b59350fc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-CA On 2020-12-02 4:19 p.m., Nathan Rossi wrote: > On Thu, 3 Dec 2020 at 05:17, Scott Branden wrote: >> Hi Nathan, >> >> Your commit: >> "cml1.bbclass: Handle ncurses-native being available via pkg-config" >> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e >> >> breaks bitbake menuconfig when using the upstream kernel. > Interesting. The purpose of the commit was to actually fix that exact > use case since previously the mainline kernel menuconfig was relying > on hardcoded paths to the host ncurses libraries. > > Would you be able to provide the error messages you are getting (and > anything else that can help to reproduce the failure), because I am > not able to reproduce any failures with a mainline kernel, linux-yocto > (with and without the below mention patch) or with other projects that > are using cml1 (e.g. u-boot). Here is the result of menuconfig with your yocto change in place:   GEN     Makefile   HOSTCC  scripts/basic/fixdep   HOSTCC  scripts/kconfig/confdata.o   HOSTCC  scripts/kconfig/expr.o   HOSTCC  scripts/kconfig/lexer.lex.o   HOSTCC  scripts/kconfig/parser.tab.o   HOSTCC  scripts/kconfig/preprocess.o   HOSTCC  scripts/kconfig/symbol.o   HOSTCC  scripts/kconfig/util.o   UPD     scripts/kconfig/mconf-cfg   HOSTCC  scripts/kconfig/mconf.o   HOSTCC  scripts/kconfig/lxdialog/checklist.o   HOSTCC  scripts/kconfig/lxdialog/inputbox.o   HOSTCC  scripts/kconfig/lxdialog/menubox.o   HOSTCC  scripts/kconfig/lxdialog/textbox.o   HOSTCC  scripts/kconfig/lxdialog/util.o   HOSTCC  scripts/kconfig/lxdialog/yesno.o   HOSTLD  scripts/kconfig/mconf scripts/kconfig/mconf  Kconfig make[2]: scripts/kconfig/mconf: Command not found /mnt/2ndHDD/yocto/nxs/poky/build/workspace/sources/brcm-linux/scripts/kconfig/Makefile:29: recipe for target 'menuconfig' failed make[2]: *** [menuconfig] Error 127 /mnt/2ndHDD/yocto/nxs/poky/build/workspace/sources/brcm-linux/Makefile:606: recipe for target 'menuconfig' failed make[1]: *** [menuconfig] Error 2 /mnt/2ndHDD/yocto/nxs/poky/build/workspace/sources/brcm-linux/Makefile:185: recipe for target '__sub-make' failed make: *** [__sub-make] Error 2 Command failed. Press any key to continue... > >> It only works with the linux-yocto kernel due to this workaround which is not upstream. >> If you revert this commit in linux-yocto menuconfig will not work in linux-yocto: >> "menuconfig,mconf-cfg: Allow specification of ncurses location" >> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/scripts/kconfig/mconf-cfg.sh?h=v5.8/standard/base&id=1714a5ad9cf61f4d0f4b8432f327cca2998aba77 > This change should not be required to have menuconfig working when > pkg-config is used. > >> >> Seems like your commit needs to be reverted or a change made to work with the upstream kernel. >> Or, the linux-yocto change needs to actually be upstreamed. I submitted it and the upstream maintainer questioned why the change is needed: >> https://lore.kernel.org/lkml/CAK7LNATD0J3C_mFrXAju8-WmdCmrPmRFn7Um0yebnfL-_zcu8w@mail.gmail.com/ > The problem is if it was accepted, every kernel prior to its inclusion > would need to be patched, as well as other projects (u-boot, busybox). > This makes supporting menuconfig using that change for kconfig > generically problematic. This is why the pkg-config solution is > preferable. > > Regards, > Nathan --000000000000e5eb4d05b59350fc Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQRQYJKoZIhvcNAQcCoIIQNjCCEDICAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg2aMIIE6DCCA9CgAwIBAgIOSBtqCRO9gCTKXSLwFPMwDQYJKoZIhvcNAQELBQAwTDEgMB4GA1UE CxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMT Ckdsb2JhbFNpZ24wHhcNMTYwNjE1MDAwMDAwWhcNMjQwNjE1MDAwMDAwWjBdMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25h bFNpZ24gMiBDQSAtIFNIQTI1NiAtIEczMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA tpZok2X9LAHsYqMNVL+Ly6RDkaKar7GD8rVtb9nw6tzPFnvXGeOEA4X5xh9wjx9sScVpGR5wkTg1 fgJIXTlrGESmaqXIdPRd9YQ+Yx9xRIIIPu3Jp/bpbiZBKYDJSbr/2Xago7sb9nnfSyjTSnucUcIP ZVChn6hKneVGBI2DT9yyyD3PmCEJmEzA8Y96qT83JmVH2GaPSSbCw0C+Zj1s/zqtKUbwE5zh8uuZ p4vC019QbaIOb8cGlzgvTqGORwK0gwDYpOO6QQdg5d03WvIHwTunnJdoLrfvqUg2vOlpqJmqR+nH 9lHS+bEstsVJtZieU1Pa+3LzfA/4cT7XA/pnwwIDAQABo4IBtTCCAbEwDgYDVR0PAQH/BAQDAgEG MGoGA1UdJQRjMGEGCCsGAQUFBwMCBggrBgEFBQcDBAYIKwYBBQUHAwkGCisGAQQBgjcUAgIGCisG AQQBgjcKAwQGCSsGAQQBgjcVBgYKKwYBBAGCNwoDDAYIKwYBBQUHAwcGCCsGAQUFBwMRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFGlygmIxZ5VEhXeRgMQENkmdewthMB8GA1UdIwQYMBaA FI/wS3+oLkUkrk1Q+mOai97i3Ru8MD4GCCsGAQUFBwEBBDIwMDAuBggrBgEFBQcwAYYiaHR0cDov L29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3RyMzA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3Js Lmdsb2JhbHNpZ24uY29tL3Jvb3QtcjMuY3JsMGcGA1UdIARgMF4wCwYJKwYBBAGgMgEoMAwGCisG AQQBoDIBKAowQQYJKwYBBAGgMgFfMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNp Z24uY29tL3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQConc0yzHxn4gtQ16VccKNm4iXv 6rS2UzBuhxI3XDPiwihW45O9RZXzWNgVcUzz5IKJFL7+pcxHvesGVII+5r++9eqI9XnEKCILjHr2 DgvjKq5Jmg6bwifybLYbVUoBthnhaFB0WLwSRRhPrt5eGxMw51UmNICi/hSKBKsHhGFSEaJQALZy 4HL0EWduE6ILYAjX6BSXRDtHFeUPddb46f5Hf5rzITGLsn9BIpoOVrgS878O4JnfUWQi29yBfn75 HajifFvPC+uqn+rcVnvrpLgsLOYG/64kWX/FRH8+mhVe+mcSX3xsUpcxK9q9vLTVtroU/yJUmEC4 OcH5dQsbHBqjMIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNV BAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAwHgYDVQQL ExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMK R2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aE yiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5 uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmmKPZpO/bL yCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hpsk+QLjJg 6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7DWzgVGkW qQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8w HQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+ yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMpjjM5 RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV3XpYKBov Hd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyrVQ4PkX42 68NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o 2HLO02JQZR7rkpeDMdmztcpHWD9fMIIFRzCCBC+gAwIBAgIMW0PXrlFB5QLwO+gIMA0GCSqGSIb3 DQEBCwUAMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQD EypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMwHhcNMjAwOTIxMTQz MTE0WhcNMjIwOTIyMTQzMTE0WjCBkDELMAkGA1UEBhMCSU4xEjAQBgNVBAgTCUthcm5hdGFrYTES MBAGA1UEBxMJQmFuZ2Fsb3JlMRYwFAYDVQQKEw1Ccm9hZGNvbSBJbmMuMRYwFAYDVQQDEw1TY290 dCBCcmFuZGVuMSkwJwYJKoZIhvcNAQkBFhpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTCCASIw DQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALCwcSIu11LCx3EwXsMF/0Te79hG0UI3NZAsVxAh exVD4CJDTVDgpCWOXj2j4V0eOvFYcGgMNVUKtywL4OzQgNquS8/OlHQZ3/9PCq8Ox9PNkCQ5eIv1 k2UaaN0tMDke1fX++Dn0UXst0OI08PYKYJpy1mkw5Hcw28LxU5Q2HwoW/+gyOIkdSo2ovq7a9+G3 LGyQOUxLhMvko/+qqg/KTfYQJ45p6TJPcvzwA0W453P3gPRZpm54KsEIfyZiMaUBMtXsQ7dHBAla I/3RRboOeC9M13VNr5feU91O0iDoMreAgPQJ0Lo7YrodKYug0Tt/fFDjkW3v3VIbEr2liUN69U0C AwEAAaOCAdEwggHNMA4GA1UdDwEB/wQEAwIFoDCBngYIKwYBBQUHAQEEgZEwgY4wTQYIKwYBBQUH MAKGQWh0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzcGVyc29uYWxzaWduMnNo YTJnM29jc3AuY3J0MD0GCCsGAQUFBzABhjFodHRwOi8vb2NzcDIuZ2xvYmFsc2lnbi5jb20vZ3Nw ZXJzb25hbHNpZ24yc2hhMmczME0GA1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIB FiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEQGA1Ud HwQ9MDswOaA3oDWGM2h0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20vZ3NwZXJzb25hbHNpZ24yc2hh MmczLmNybDAlBgNVHREEHjAcgRpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTATBgNVHSUEDDAK BggrBgEFBQcDBDAfBgNVHSMEGDAWgBRpcoJiMWeVRIV3kYDEBDZJnXsLYTAdBgNVHQ4EFgQUWOK7 qiyDSt/IDm/SRcNi/sTEiyswDQYJKoZIhvcNAQELBQADggEBAEe2edd4F9tpp0GPmrFrQ+xp9kY7 uxBzPdCw588bgVrPemjLwiwV37XTT4iWJtNhPfEpaguM6jeLm58LCvHq5/IBjcyHyf4URQVwAg7B pqkH8/M+IBstu4/D+znPHB59X+c+au3Q8D+xoNFd7I30kaE+oJuBuFsGXRBc0Ci+FM86x9k7SF8U aui1E7Y9wDfsRSCL2TSwU773f09WkrvVdlKxNqQZj2z7bQUUn+yfXdFfBz0LqlYNfn7xJOpQE3HI H4jq6U9+b0Qf+J0n0wyysjXPSeQ7EKXVkT8dM2KSpIN86v5dd9LkAz3C1dmjuPRGEC8ZhI1IjMBt 0itrn6C23NsxggJvMIICawIBATBtMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWdu IG52LXNhMTMwMQYDVQQDEypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0g RzMCDFtD165RQeUC8DvoCDANBglghkgBZQMEAgEFAKCB1DAvBgkqhkiG9w0BCQQxIgQgKXCuE1QK yayZaFi2/pfud60b9eyFDTvRFX6HtF+v7cowGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkq hkiG9w0BCQUxDxcNMjAxMjAzMTgxMzI1WjBpBgkqhkiG9w0BCQ8xXDBaMAsGCWCGSAFlAwQBKjAL BglghkgBZQMEARYwCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMAsGCSqGSIb3DQEBCjALBgkqhkiG 9w0BAQcwCwYJYIZIAWUDBAIBMA0GCSqGSIb3DQEBAQUABIIBACBfgfhOPAOb7n9zVJZYzzMEafT1 zarhSiAHZk0O8BzFm+QEMXVef8O53G40AI+j5kurrAJ6x6gl396wvXUSY+ciGnSsJO8tj/PPB9Iz NO3OR8sFzXYxRmfs+sceWU9yclM70rNQD14Aa1BNcfcZZGQvipCWOuWzzCXEmROiUtWqwMi4z07e NfPmsZqGNBOLXqeWcvsYy3qtdUlPrkkFGvFzReM9d6USCtYJtQAcDpT7bwBsxgJPizdoRD78dUQB Xcs5fg0XoCC0STj5tBdb7J+S8bdU6wC5s67pTetxg8eKinS02kQSYxyu5wbKhP2YLfmntwPnu+51 /siA1No+8fU= --000000000000e5eb4d05b59350fc--