From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Taras Kondratiuk <takondra@cisco.com>
Cc: xe-linux-external@cisco.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] devtool: prevent starting git gc in background
Date: Fri, 22 Mar 2019 12:25:57 +1300 [thread overview]
Message-ID: <7654089.vcRqMmA28I@localhost.localdomain> (raw)
In-Reply-To: <1553209705-12220-1-git-send-email-takondra@cisco.com>
Hi Taras
On Friday, 22 March 2019 12:08:25 PM NZDT Taras Kondratiuk wrote:
> Devtool creates a git repository for extracted sources in a temporary
> directory and then moves it to a final destination after patching is
> done. Unfortunately devtool is not aware that some of its git operations
> may have caused git garbage collector to start in background. If timing
> is just right a repository move fails because GC is removing git objects
> while they are being moved.
>
> The issue was hit on Krogoth release, but the code that moves created
> git repository is still the same.
>
> Disable gc.autodetach to make GC run synchronously and block git until
> it is done.
The fix is OK, but I'd like it to be explicit and say "git config --local"
rather than just "git config" just in case of any future behavioral
changes in git config. Could you please send a v2 with this change?
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2019-03-21 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 23:08 [PATCH] devtool: prevent starting git gc in background Taras Kondratiuk
2019-03-21 23:25 ` Paul Eggleton [this message]
2019-03-22 0:56 ` [PATCH v2] " Taras Kondratiuk
2019-04-01 22:53 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7654089.vcRqMmA28I@localhost.localdomain \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=takondra@cisco.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox