From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Zhang Xiao <xiao.zhang@windriver.com>,
openembedded-core@lists.openembedded.org,
mark.hatle@windriver.com
Subject: Re: [PATCH 1/7] eudev: fix file conflict when multilib enabled
Date: Mon, 12 Mar 2018 12:13:48 +0200 [thread overview]
Message-ID: <7673ca98-3ed5-c770-180e-88d599736d92@linux.intel.com> (raw)
In-Reply-To: <20180312091303.121887-1-xiao.zhang@windriver.com>
On 03/12/2018 11:12 AM, Zhang Xiao wrote:
> Config file udev.pc conflicts between 32 and 64 bit packages.
> Use update-alternatives to add base_libdir as suffix to avoid it.
> -inherit autotools update-rc.d qemu pkgconfig distro_features_check
> +inherit autotools update-rc.d qemu pkgconfig distro_features_check update-alternatives
> +
> +MULTILIB_SUFFIX = "${@d.getVar('base_libdir',1).split('/')[-1]}"
> +
> +ALTERNATIVE_${PN}-dev = "udev.pc"
> +ALTERNATIVE_LINK_NAME[udev.pc] = "${datadir}/pkgconfig/udev.pc"
> +ALTERNATIVE_TARGET[udev.pc] = "${datadir}/pkgconfig/udev.pc-${MULTILIB_SUFFIX}"
> +
> +PACKAGE_PREPROCESS_FUNCS += "eudev_alternative_rename"
> +
> +eudev_alternative_rename() {
> + # rename udev.pc
> + mv ${PKGD}${datadir}/pkgconfig/udev.pc ${PKGD}${datadir}/pkgconfig/udev.pc-${MULTILIB_SUFFIX}
> +}
I'm afraid, I have to say no to the entire patchset. It's abusing
update-alternatives to do what it was never meant for, and effectively
renders one of the -dev packages broken, just so that package manager
can satisfy dependencies.
Let's first take a look at why dnf wants to install two different -dev
packages in the first place, and why these seven recipes need to be
fixed in particular. My understanding is multilib feature should be used
only for libraries, and not for supporting development files.
Alex
next prev parent reply other threads:[~2018-03-12 10:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:12 [PATCH 1/7] eudev: fix file conflict when multilib enabled Zhang Xiao
2018-03-12 9:12 ` [PATCH 2/7] python3: " Zhang Xiao
2018-03-12 9:12 ` [PATCH 3/7] vala: " Zhang Xiao
2018-03-12 9:13 ` [PATCH 4/7] gobject-introspection: " Zhang Xiao
2018-03-12 9:13 ` [PATCH 5/7] cairo: " Zhang Xiao
2018-03-16 15:56 ` Burton, Ross
2018-03-12 9:13 ` [PATCH 6/7] xtrans: " Zhang Xiao
2018-03-16 15:55 ` Burton, Ross
2018-03-12 9:13 ` [PATCH 7/7] icu: " Zhang Xiao
2018-03-12 10:13 ` Alexander Kanavin [this message]
2018-03-12 18:38 ` [PATCH 1/7] eudev: " Mark Hatle
2018-03-12 18:55 ` Alexander Kanavin
2018-03-12 19:48 ` Mark Hatle
2018-03-13 10:19 ` Alexander Kanavin
2018-03-26 15:28 ` Mark Hatle
2018-03-27 10:37 ` Alexander Kanavin
2018-03-27 14:38 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7673ca98-3ed5-c770-180e-88d599736d92@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=xiao.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox