Re: [OE-core] [PATCH v1] core-image, populate_sdk_base: Add zsh-completion-pkgs image feature

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2025-10-07 at 11:48 +0000, Peter Kjellerstedt via lists.openembedded.org wrote:
> > -----Original Message-----
> > From: Ross Burton <Ross.Burton@arm.com>
> > Sent: den 7 oktober 2025 12:34
> > To: Khem Raj <raj.khem@gmail.com>
> > Cc: Adam X Nilsson <Adam.X.Nilsson@axis.com>; openembedded-core@lists.openembedded.org; Adam X Nilsson <Adam.X.Nilsson@axis.com>; Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > Subject: Re: [OE-core] [PATCH v1] core-image, populate_sdk_base: Add zsh-completion-pkgs image feature
> > 
> > On 6 Oct 2025, at 22:28, Khem Raj <raj.khem@gmail.com> wrote:
> > > 
> > > On Mon, Oct 6, 2025 at 1:10 PM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote:
> > > > 
> > > > On 1 Oct 2025, at 17:02, Adam Nilsson via lists.openembedded.org <Adam.X.Nilsson=axis.com@lists.openembedded.org> wrote:
> > > > > 
> > > > > From: Adam Nilsson <adamni@axis.com>
> > > > > 
> > > > > Add a zsh-completion-pkgs image feature to install *-zsh-completion
> > > > > packages into an image. This is similar to the existing
> > > > > bash-completion-pkgs feature.
> > > > 
> > > > By my count there’s just three recipes in core that have -zsh-
> > > > completion packages.  Until it’s more common, I’d suggest putting the
> > > > COMPLEMENTARY_GLOBS assignment in your own image recipe if you want to use
> > > > it.
> > > 
> > > It does help people using zsh as default shell and working with yocto SDKs.
> > 
> > Does it though?
> > 
> > $ git grep FILES.*zsh-completion
> > meta/recipes-core/systemd/systemd_257.8.bb:FILES:${PN}-zsh-completion = "${datadir}/zsh/site-functions"
> > meta/recipes-devtools/patchelf/patchelf_0.18.0.bb:FILES:${PN}-zsh-completion = "${datadir}/zsh"
> > meta/recipes-kernel/kmod/kmod_34.2.bb:FILES:${PN}-zsh-completion = "${datadir}/zsh”
> > 
> > How many SDKs ship with nativesdk builds of systemd, patchelf, or kmod?
> > 
> > Ross
> 
> Please think outside OE-Core. Just because there are only three recipes 
> in OE-Core that currently create zsh-completion packages, does not mean 
> that it is not more common outside of OE-Core. Also, one recipe that 
> could benefit from creating a zsh-completion package is bluez5, which
> currently has it disabled.
> 
> One of the main reasons I suggested Adam to send this patch upstream 
> is for consistency. Since bash-completions-pkgs is a well established
> feature, I would expect the same possibility for others shells (which
> in our case happens to be zsh).

I'm not sure we should have let the bash-completions one in. Now that
we have, we have the inevitable followups and this is why I worry a lot
about precedent when merging patches as people do use it against me
later.

One the one hand, it is a trivial patch. On the other, we have key
features like dev packages and dbg packages being mixed with much lower
priority things like shell completion. This makes it harder for new
users to find the important takeaways from the less important ones.

I really don't know what to do with the patch. I'm not particularly
keen on it and my first impression was no, equally, I'm burnt out and
really don't have the time/energy to write long emails arguing points
about it.

Cheers,

Richard