Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jose Quaresma <quaresma.jose@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
	Jose Quaresma <jose.quaresma@foundries.io>
Subject: Re: [OE-core] [RFC OE-core][PATCH 2/2] go-runtime: fixme: buildpaths
Date: Fri, 01 Nov 2024 22:45:29 +0000	[thread overview]
Message-ID: <7814ec4f59c97b31d8bc974de9b117b8fce5c843.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANPvuR=yRLzEK6G1RGQjMBOipkNiVWxWNyCMfpvtwOE-aDJhPA@mail.gmail.com>

On Thu, 2024-10-31 at 12:12 +0000, Jose Quaresma wrote:
> 
> 
> Richard Purdie <richard.purdie@linuxfoundation.org> escreveu (quarta,
> 30/10/2024 à(s) 19:40):
> > On Wed, 2024-10-30 at 18:19 +0000, Jose Quaresma via
> > lists.openembedded.org wrote:
> > > 
> > > 
> > > Jose Quaresma via lists.openembedded.org
> > > <quaresma.jose=gmail.com@lists.openembedded.org> escreveu
> > > (quarta,
> > > 30/10/2024 à(s) 18:18):
> > > > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> > > > ---
> > > >  meta/recipes-devtools/go/go-runtime_1.23.0.bb | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/meta/recipes-devtools/go/go-runtime_1.23.0.bb
> > > > b/meta/recipes-devtools/go/go-runtime_1.23.0.bb
> > > > index 63464a1501..a9a4e2a044 100644
> > > > --- a/meta/recipes-devtools/go/go-runtime_1.23.0.bb
> > > > +++ b/meta/recipes-devtools/go/go-runtime_1.23.0.bb
> > > > @@ -1,3 +1,4 @@
> > > >  require go-${PV}.inc
> > > >  require go-runtime.inc
> > > > 
> > > > +INSANE_SKIP:${PN} += "buildpaths"
> > > > 
> > > 
> > > 
> > > Send this as RFC mostly because of this.
> > 
> > That suggests it will fail the reproducibility tests too :(
> > 
> > We're going to have to address those issues really. I guess the
> > patch
> > gives us something to start with and collaborate around...
> > 
> > Cheers,
> > 
> > Richard
> 
> I would like to finish this update but I have been very busy at the
> moment
> and I don't know when I will be able to get back to it.

FWIW, adding a -trimpath to the go_bootstrap line in do_compile in go-
runtime does remove a lot of the paths. It leaves one single path
reference in libstd.so in the .rodata section, I think corresponding to
GOROOT. I couldn't work that one out though.

Cheers,

Richard







  reply	other threads:[~2024-11-01 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 18:17 [RFC OE-core][PATCH 1/2] go: bump 1.23.0 Jose Quaresma
2024-10-30 18:17 ` [RFC OE-core][PATCH 2/2] go-runtime: fixme: buildpaths Jose Quaresma
     [not found] ` <18034DD8CF292769.12341@lists.openembedded.org>
2024-10-30 18:19   ` [OE-core] " Jose Quaresma
2024-10-30 19:40     ` Richard Purdie
2024-10-31 12:12       ` Jose Quaresma
2024-11-01 22:45         ` Richard Purdie [this message]
2024-11-06 11:09           ` Jose Quaresma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7814ec4f59c97b31d8bc974de9b117b8fce5c843.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jose.quaresma@foundries.io \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quaresma.jose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox