Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable

Ross Burton
2022-10-19T15:29:44Z

On 19 Oct 2022, at 07:34, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
>
> On Tue, Oct 18, 2022 at 10:42 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
>>
>> Can you show examples where this is needed? Custom variable does not seem a good idea. I also worry that it’ll break automated updates (it’s bad enough with mesa-gl, this might make it worse).
>
> https://github.com/ndechesne/meta-qcom/blob/master/recipes-graphics/mesa/mesa_git.bb

That is, well, horrible.

*If* we’re going to expose a mesa.inc that people outside of core can use to package up their own random Mesa SHA then mesa.inc should just be the packaging logic.

However, I don’t understand something about the patch.

Why do we only need to apply it on native builds? It’s a backport from upstream, so should be the fix. If it breaks when applied to target builds, is there a bug upstream for that?

Ross