Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable

Alexander Kanavin
2022-10-19T16:05:14Z

Khem, sorry but no. We have well defined mechanisms for reuse, and
including bits and pieces of recipes from completely different layers
is not one of them. I do not want to hear even more complaints about
'breaking' things than I already do when trying to make things better,
simpler and more maintainable, and I do not want to be paralysed by
fear of invisible breakage in custom layers when doing so.

If you *really* want to make bits of mesa recipe 'public', put them in
a bbclass.

Alex

On Wed, 19 Oct 2022 at 17:29, Ross Burton <Ross.Burton@arm.com> wrote:
>
> On 19 Oct 2022, at 07:34, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >
> > On Tue, Oct 18, 2022 at 10:42 PM Alexander Kanavin
> > <alex.kanavin@gmail.com> wrote:
> >>
> >> Can you show examples where this is needed? Custom variable does not seem a good idea. I also worry that it’ll break automated updates (it’s bad enough with mesa-gl, this might make it worse).
> >
> > https://github.com/ndechesne/meta-qcom/blob/master/recipes-graphics/mesa/mesa_git.bb
>
> That is, well, horrible.
>
> *If* we’re going to expose a mesa.inc that people outside of core can use to package up their own random Mesa SHA then mesa.inc should just be the packaging logic.
>
> However, I don’t understand something about the patch.
>
> Why do we only need to apply it on native builds? It’s a backport from upstream, so should be the fix. If it breaks when applied to target builds, is there a bug upstream for that?
>
> Ross