Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable

Alexander Kanavin
2022-10-19T05:42:20Z

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]

Can you show examples where this is needed? Custom variable does not seem a
good idea. I also worry that it’ll break automated updates (it’s bad enough
with mesa-gl, this might make it worse).

Alex

On Wed 19. Oct 2022 at 1.08, Khem Raj <raj.khem@gmail.com> wrote:

> This helps override the SRC_URI in entirety if needed by
> and overriding recipe
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Kai Kang <kai.kang@windriver.com>
> ---
> v2: Weakly define NATIVE_PATCHES
>
> meta/recipes-graphics/mesa/mesa.inc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc
> b/meta/recipes-graphics/mesa/mesa.inc
> index c94e439363..04d78a6aa5 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -19,10 +19,11 @@ SRC_URI = "
> https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> file://0001-meson-misdetects-64bit-atomics-on-mips-clang.patch
> \
>
> file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
> file://0001-util-format-Check-for-NEON-before-using-it.patch \
> + ${NATIVE_PATCHES} \
> "
> -
> +NATIVE_PATCHES ?= ""
> # required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD
> enabled
> -SRC_URI:append:class-native = "
> file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
> +NATIVE_PATCHES:class-native =
> "file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
>
> SRC_URI[sha256sum] =
> "b1f9c8fd08f2cae3adf83355bef4d2398e8025f44947332880f2d0066bdafa8c"
>
> --
> 2.38.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171948):
> https://lists.openembedded.org/g/openembedded-core/message/171948
> Mute This Topic: https://lists.openembedded.org/mt/94420106/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3385 bytes --]