Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable

Martin Jansa
2022-10-19T16:06:04Z

[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]

On Wed, Oct 19, 2022 at 5:29 PM Ross Burton <ross.burton@arm.com> wrote:

> On 19 Oct 2022, at 07:34, Khem Raj via lists.openembedded.org <raj.khem=
> gmail.com@lists.openembedded.org> wrote:
> >
> > On Tue, Oct 18, 2022 at 10:42 PM Alexander Kanavin
> > <alex.kanavin@gmail.com> wrote:
> >>
> >> Can you show examples where this is needed? Custom variable does not
> seem a good idea. I also worry that it’ll break automated updates (it’s bad
> enough with mesa-gl, this might make it worse).
> >
> >
> https://github.com/ndechesne/meta-qcom/blob/master/recipes-graphics/mesa/mesa_git.bb
>
> That is, well, horrible.
>
> *If* we’re going to expose a mesa.inc that people outside of core can use
> to package up their own random Mesa SHA then mesa.inc should just be the
> packaging logic.
>

Well I've seen many mesa/pulseaudio recipes which were using
mesa.inc/pulseaudio.inc and even when they were a bit terrible, then it was
still better than duplicating all of it. e.g.
https://github.com/webOS-ports/meta-pine64-luneos/commits/8946d3e2350ae83fbb001ba640db59b207341481/recipes-graphics/mesa/mesa_%25.bbappend
https://github.com/shr-project/meta-webosose/commits/master/meta-webos/recipes-multimedia/pulseaudio

And better than some other recipes which start with "require
recipes-foo/foos/foo_1.0.bb" and then set PV to 2.0 and do few other
changes.

I never expected .inc file to be _required_ wide range of possible
versions, people who re-use it to build older or newer version need to deal
with possible incompatibilities in their layer even if it sometimes might
require whole .inc file to be imported into their layer, when the benefit
of reusing it is much smaller than required modifications (e.g. when
pulseaudio in oe-core was upgraded to use meson while our old version was
still built with autotools or even this small change, but in :prepend
https://git.openembedded.org/openembedded-core/commit/?id=e5399a09bf44700f97607b283379172dac0cf9c7
.

>
> However, I don’t understand something about the patch.
>
> Why do we only need to apply it on native builds? It’s a backport from
> upstream, so should be the fix. If it breaks when applied to target
> builds, is there a bug upstream for that?

FWIW: I've reported that it breaks builds with DEBUG_BUILD instead of
fixing them in:
https://lists.openembedded.org/g/openembedded-core/message/169002
but Kai replied that it still works for him until it didn't which probably
lead to this change to apply it only in master.

I've reported the same in upstream MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17439#note_1499443
but I didn't create new ticket about it (as it was supposed to work for
others).

Cheers,

[-- Attachment #2: Type: text/html, Size: 4364 bytes --]