public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: "André Draszik" <git@andred.net>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] libnl: fix packaging mistakes
Date: Fri, 26 Aug 2016 12:02:58 -0700	[thread overview]
Message-ID: <78584d41-d0c2-058c-c048-fb5864e24383@gmail.com> (raw)
In-Reply-To: <20160826103152.6211-1-git@andred.net>

this series looks ok to me.

On 8/26/16 3:31 AM, André Draszik wrote:
> - *.la files belong into -dev packages
> - the genl-ctrl-list command line utility should go to into the CLI
>   package, so as to prevent the libnl-genl library package from
>   pulling in all of the command line utilities (as genl-ctrl-list
>   is linked against libnl-cli-3.so.200)
> 
> Signed-off-by: André Draszik <git@andred.net>
> ---
>  meta/recipes-support/libnl/libnl_3.2.25.bb | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/recipes-support/libnl/libnl_3.2.25.bb b/meta/recipes-support/libnl/libnl_3.2.25.bb
> index cabe841..2624915 100644
> --- a/meta/recipes-support/libnl/libnl_3.2.25.bb
> +++ b/meta/recipes-support/libnl/libnl_3.2.25.bb
> @@ -25,18 +25,18 @@ FILES_${PN} = "${libdir}/libnl-3.so.* \
>                 ${sysconfdir}"
>  RREPLACES_${PN} = "libnl2"
>  RCONFLICTS_${PN} = "libnl2"
> +FILES_${PN}-dev += "${libdir}/libnl/cli/*/*.la"
>  FILES_${PN}-staticdev += "${libdir}/libnl/cli/*/*.a"
>  
> -PACKAGES += "${PN}-cli ${PN}-route ${PN}-nf ${PN}-genl ${PN}-idiag"
> +PACKAGES += "${PN}-cli ${PN}-genl ${PN}-idiag ${PN}-nf ${PN}-route"
>  FILES_${PN}-cli   = "${libdir}/libnl-cli-3.so.* \
>                       ${libdir}/libnl/cli/*/*.so \
> -                     ${libdir}/libnl/cli/*/*.la \
> +                     ${sbindir}/genl-ctrl-list \
>                       ${sbindir}/nl-*"
> -FILES_${PN}-route = "${libdir}/libnl-route-3.so.*"
> +FILES_${PN}-genl  = "${libdir}/libnl-genl-3.so.* \
> +                     ${libdir}/libnl-genl.so.*"
>  FILES_${PN}-idiag = "${libdir}/libnl-idiag-3.so.*"
>  FILES_${PN}-nf    = "${libdir}/libnl-nf-3.so.*"
> -FILES_${PN}-genl  = "${libdir}/libnl-genl-3.so.* \
> -                     ${libdir}/libnl-genl.so.* \
> -                     ${sbindir}/genl-ctrl-list"
> +FILES_${PN}-route = "${libdir}/libnl-route-3.so.*"
>  RREPLACES_${PN}-genl = "libnl-genl2 libnl-genl-3-200"
>  RCONFLICTS_${PN}-genl = "libnl-genl2 libnl-genl-3-200"
> 


  parent reply	other threads:[~2016-08-26 19:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 10:31 [PATCH 1/3] libnl: fix packaging mistakes André Draszik
2016-08-26 10:31 ` [PATCH 2/3] libnl: update to v3.2.28 André Draszik
2016-08-26 10:31 ` [PATCH 3/3] libnl: backport musl fix (strerror_r / strerror_l) André Draszik
2016-08-26 19:02 ` Khem Raj [this message]
2016-09-01  8:19 ` [PATCH 1/3] libnl: fix packaging mistakes Robert Yang
2016-09-01 16:04   ` André Draszik
2016-09-02  5:18     ` Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78584d41-d0c2-058c-c048-fb5864e24383@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox