public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][kirkstone 16/19] cracklib: Modify patch to compile with GCC 14
Date: Tue, 29 Oct 2024 11:59:49 -0700	[thread overview]
Message-ID: <7cca344feaa16cfabbaa2f34e4aab91cc1af39ee.1730228268.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1730228268.git.steve@sakoman.com>

From: Zoltan Boszormenyi <zboszor@gmail.com>

GCC 14 implicitly turns a warning into a compiler error:

| ../../git/src/lib/packlib.c: In function ‘PWClose’:
| ../../git/src/lib/packlib.c:554:40: error: passing argument 1 of ‘HwmsHostToBigEndian’ from incompatible pointer type [-Wincompatible-pointer-types]
|   554 |             HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
|       |                                 ~~~~~~~^~~~~
|       |                                        |
|       |                                        uint32_t * {aka unsigned int *}
| ../../git/src/lib/packlib.c:142:27: note: expected ‘char *’ but argument is of type ‘uint32_t *’ {aka ‘unsigned int *’}
|   142 | HwmsHostToBigEndian(char *pHwms, int nLen,int nBitType)
|       |                     ~~~~~~^~~~~

Add the cast to (char *) to silence it.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 ...0001-packlib.c-support-dictionary-byte-order-dependent.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch b/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch
index 8fb512a224..cf7a0857e0 100644
--- a/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch
+++ b/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch
@@ -303,7 +303,7 @@ index 8acb7be..a9d8750 100644
 +	    PWDICT tmp_pwp;
 +
 +	    memcpy(&tmp_pwp, pwp, sizeof(PWDICT));
-+	    HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
++	    HwmsHostToBigEndian((char *)tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
 +	    fwrite(tmp_pwp.hwms, 1, sizeof(tmp_pwp.hwms), pwp->wfp);
  	}
      }
-- 
2.34.1



  parent reply	other threads:[~2024-10-29 19:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 18:59 [OE-core][kirkstone 00/19] Patch review Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 01/19] ghostscript: Backport CVE-2024-29508 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 02/19] openssl: patch CVE-2024-9143 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 03/19] qemu: fix CVE-2023-3019 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 04/19] python3: ignore fixed CVEs Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 05/19] cve-check: add CVSS vector string to CVE database and reports Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 06/19] cve-check: add support for cvss v4.0 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 07/19] vim: Upgrade 9.1.0682 -> 9.1.0698 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 08/19] vim: Upgrade 9.1.0698 -> 9.1.0764 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 09/19] orc: upgrade 0.4.39 -> 0.4.40 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 10/19] overlayfs-etc: add option to skip creation of mount dirs Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 11/19] bmap-tools: update HOMEPAGE and SRC_URI Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 12/19] nativesdk-intercept: Fix bad intercept chgrp/chown logic Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 13/19] zip: Make configure checks to be more robust Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 14/19] zip: Fix build with gcc-14 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 15/19] vala: add -Wno-error=incompatible-pointer-types work around Steve Sakoman
2024-10-29 18:59 ` Steve Sakoman [this message]
2024-10-29 18:59 ` [OE-core][kirkstone 17/19] libffi: backport a fix to build libffi-native with gcc-14 Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 18/19] at-spi2-core: backport a patch to fix build with gcc-14 on host Steve Sakoman
2024-10-29 18:59 ` [OE-core][kirkstone 19/19] util-linux: Define pidfd_* function signatures Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cca344feaa16cfabbaa2f34e4aab91cc1af39ee.1730228268.git.steve@sakoman.com \
    --to=steve@sakoman.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox