From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Konrad Weihmann <kweihmann@outlook.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] ruby: properly append PACKAGECONFIG
Date: Wed, 03 Jun 2020 09:44:30 +0100 [thread overview]
Message-ID: <7deef78bc70f79f48cc8d9da5c0e18bcb305cfbb.camel@linuxfoundation.org> (raw)
In-Reply-To: <AM7PR05MB688165541EEC54AF8DE1016DA88B0@AM7PR05MB6881.eurprd05.prod.outlook.com>
On Tue, 2020-06-02 at 22:44 +0200, Konrad Weihmann wrote:
> As ??= assignment will be overwritten by += in any case,
> one can't define a default of PACKAGECONFIG in this recipe.
> Using _append instead mitigates chances of accidental overwriting
> the default
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
> meta/recipes-devtools/ruby/ruby_2.7.1.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/ruby/ruby_2.7.1.bb b/meta/recipes-
> devtools/ruby/ruby_2.7.1.bb
> index 3dd9fb0a62..3d7d095fbf 100644
> --- a/meta/recipes-devtools/ruby/ruby_2.7.1.bb
> +++ b/meta/recipes-devtools/ruby/ruby_2.7.1.bb
> @@ -12,7 +12,7 @@ SRC_URI[md5sum] =
> "debb9c325bf65021214451660f46e909"
> SRC_URI[sha256sum] =
> "d418483bdd0000576c1370571121a6eb24582116db0b7bb2005e90e250eae418"
>
> PACKAGECONFIG ??= ""
> -PACKAGECONFIG += "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
> +PACKAGECONFIG_append = " ${@bb.utils.filter('DISTRO_FEATURES',
> 'ipv6', d)}"
Shouldn't this just be:
PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
?
Cheers,
Richard
next prev parent reply other threads:[~2020-06-03 8:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200602204418.26224-1-kweihmann@outlook.com>
2020-06-02 20:44 ` [PATCH] debianutils: whitespace fixes Konrad Weihmann
2020-06-02 20:44 ` [PATCH] libjpeg-turbo: " Konrad Weihmann
2020-06-02 20:44 ` [PATCH] cairo: remove trailing whitespace Konrad Weihmann
2020-06-02 20:44 ` [PATCH] gtk-doc: " Konrad Weihmann
2020-06-02 20:44 ` [PATCH] libxt: fix whitespaces Konrad Weihmann
2020-06-02 20:44 ` [PATCH] cogl: point to correct HOMEPAGE Konrad Weihmann
2020-06-02 20:44 ` [PATCH] ruby: properly append PACKAGECONFIG Konrad Weihmann
2020-06-03 8:44 ` [OE-core] " Richard Purdie
2020-06-03 8:44 ` Richard Purdie [this message]
2020-06-03 11:03 ` Konrad Weihmann
2020-06-03 11:19 ` Richard Purdie
2020-06-03 11:35 ` Konrad Weihmann
2020-06-02 20:44 ` [PATCH] vim-tiny: " Konrad Weihmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7deef78bc70f79f48cc8d9da5c0e18bcb305cfbb.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kweihmann@outlook.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox