Re: [OE-core] [PATCH] oeqa/runtime: fix regression in minidebuginfo test

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2024-05-29 at 12:08 +0200, Etienne Cordonnier via lists.openembedded.org wrote:
> From: Etienne Cordonnier <ecordonnier@snap.com>
> 
> The builtin command "sleep" was getting executed instead of the busybox binary.
> Hence "pidof sleep" was empty and the test was failing.
> 
> Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
> ---
>  meta/lib/oeqa/runtime/cases/systemd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/systemd.py b/meta/lib/oeqa/runtime/cases/systemd.py
> index 5481e1d840..a2229848e7 100644
> --- a/meta/lib/oeqa/runtime/cases/systemd.py
> +++ b/meta/lib/oeqa/runtime/cases/systemd.py
> @@ -145,7 +145,7 @@ class SystemdServiceTests(SystemdTest):
>          Verify that call-stacks generated by systemd-coredump contain symbolicated call-stacks,
>          extracted from the minidebuginfo metadata (.gnu_debugdata elf section).
>          """
> -        t_thread = threading.Thread(target=self.target.run, args=("ulimit -c unlimited && sleep 1000",))
> +        t_thread = threading.Thread(target=self.target.run, args=("ulimit -c unlimited && /usr/bin/sleep 1000",))
>          t_thread.start()
>          time.sleep(1)

I get a bit nervous about hardcoding paths like "/usr/bin",
particularly in the context of some distros liking to move things
around. We may want to put a shutil.which("sleep") call in instead (and
an import shutil if needed)?

Cheers,

Richard