Re: [PATCH] valgrind: MIPS: Make toolchain basename generic

[Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>]

Hi

On 09/08/2016 04:45 PM, akuster808 wrote:
>
>
> On 09/08/2016 06:14 AM, Zubair Lutfullah Kakakhel wrote:
>> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
>> since OE can support multiple distro layers, not just poky.
>>
>> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
>
> is this good for Krogoth too? it has the same version.

Yes. But we'd also need this commit from master

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb?id=d7268e9bbae93455a591bb4f73bfe4bf76497a1b

They can both be squashed into one commit.

Thanks,
ZubairLK

>
> - armin
>>
>> ---
>> Pointed out by Andre McCurdy but patch v1 had already been accepted
>> and applied.
>> ---
>>   meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> index 3d49131..42fd27f 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
>>   COMPATIBLE_HOST_armv6 = 'null'
>>
>>   # valgrind doesn't like mips soft float
>> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips-poky-linux", d)}"
>> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel-poky-linux", d)}"
>> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>>
>>   inherit autotools ptest
>>
>