Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] oeqa/selftest/distrodata: Port to use the new recipeutils.get_recipe_upgrade_status() function
Date: Fri, 14 Dec 2018 22:54:53 +0000	[thread overview]
Message-ID: <818babcd1dfc54b1233a5ccdaeea9a94e8d2ab87.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj8aDC6L66bSkAgMCT5dxmWMsMAEKMsixGWCvcaoUd8fbg@mail.gmail.com>

On Fri, 2018-12-14 at 19:28 +0100, Alexander Kanavin wrote:
> On Fri, 14 Dec 2018 at 19:16, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > @@ -17,11 +19,11 @@ class Distrodata(OESelftestTestCase):
> >          feature = 'INHERIT += "distrodata"\n'
> >          feature += 'LICENSE_FLAGS_WHITELIST += " commercial"\n'
> 
> ^^^^ These are no longer needed? Otherwise, looks fantastic!

The license flags may not be, the distrodata is still needed right now
to inherit the maintainers include file.

I will add a patch to do that by default, then we can drop the class
and the inherit. The license flags variable needs investigation so can
also be a followup...

Cheers,

Richard



  reply	other threads:[~2018-12-14 22:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 18:15 [PATCH 1/2] lib/oe/recipeutils: Add a new function to mimic do_checkpkg Richard Purdie
2018-12-14 18:15 ` [PATCH 2/2] oeqa/selftest/distrodata: Port to use the new recipeutils.get_recipe_upgrade_status() function Richard Purdie
2018-12-14 18:28   ` Alexander Kanavin
2018-12-14 22:54     ` Richard Purdie [this message]
2018-12-14 18:35 ` ✗ patchtest: failure for "lib/oe/recipeutils: Add a new ..." and 1 more Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=818babcd1dfc54b1233a5ccdaeea9a94e8d2ab87.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox