From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] util-linux: fix PACKAGECONFIG options
Date: Tue, 30 Jul 2013 11:50:58 +0100 [thread overview]
Message-ID: <8237333.h1yk84NkVT@helios> (raw)
In-Reply-To: <7891D5A0-7EB3-4A7A-99EC-962DC7EF9764@gmail.com>
On Tuesday 30 July 2013 01:52:42 Khem Raj wrote:
> On Jul 26, 2013, at 12:01 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> > Op 25 jul. 2013, om 16:51 heeft Koen Kooi <koen@dominion.thruhere.net> het
volgende geschreven:
> >> The ??= operator is too weak and it's setting a non-existent
> >> PACKAGECONFIG option ('libpam' instead of 'pam').
> >>
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/recipes-core/util-linux/util-linux.inc | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-core/util-linux/util-linux.inc
> >> b/meta/recipes-core/util-linux/util-linux.inc index d373cec..3d1198a
> >> 100644
> >> --- a/meta/recipes-core/util-linux/util-linux.inc
> >> +++ b/meta/recipes-core/util-linux/util-linux.inc
> >> @@ -47,9 +47,9 @@ EXTRA_OECONF = "--libdir=${base_libdir}
> >> --disable-use-tty-group \>>
> >> --enable-libuuid --enable-libblkid --enable-fsck
> >> --without-udev \
> >>
> >> usrsbin_execdir='${sbindir}' \
> >>
> >> "
> >> -PACKAGECONFIG_class-target ??= "${@base_contains('DISTRO_FEATURES',
> >> 'pam', 'libpam', '', d)} \ +PACKAGECONFIG_class-target ?=
> >> "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \>>
> >> ${@base_contains('DISTRO_FEATURES',
> >> 'systemd', 'systemd', '', d)} "
> >>
> >> -PACKAGECONFIG[pam] = "--enable-su --enable-runuser,--disable-su
> >> --disable-runuser, pam," +PACKAGECONFIG[pam] = "--enable-su
> >> --enable-runuser,--disable-su --disable-runuser, libpam,"
> >>
> >> # Respect the systemd feature for uuidd
> >> PACKAGECONFIG[systemd] = "--enable-socket-activation
> >> --with-systemdsystemunitdir=${systemd_unitdir}/system/,
> >> --disable-socket-activation --without-systemdsystemunitdir">
> > And of course this will trigger another bug:
> > | * check_data_file_clashes: Package util-linux wants to install file
> > | /build/v2013.06/build/tmp-angstrom_v2013_06-eglibc/work/beaglebone-ang
> > | strom-linux-gnueabi/cloud9-image/1.0-r0/rootfs/usr/bin/su> |
> > | But that file is already provided by package * shadow
> >
> > *sigh*
>
> +*sigh*
>
> has this been fixed yet ? just ran into same issue
The patch to fix it is in Saul's most recent consolidated pull.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-07-30 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 14:51 [PATCH] util-linux: fix PACKAGECONFIG options Koen Kooi
2013-07-26 7:01 ` Koen Kooi
2013-07-26 9:01 ` Hongxu Jia
2013-07-30 8:52 ` Khem Raj
2013-07-30 10:50 ` Paul Eggleton [this message]
2013-07-30 15:31 ` Khem Raj
2013-07-30 15:35 ` Saul Wold
2013-07-30 17:30 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8237333.h1yk84NkVT@helios \
--to=paul.eggleton@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox