Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Michael Gloff <mgloff@emacinc.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] sysvinit: Remove ${B} assignment
Date: Sat, 12 Sep 2020 20:11:24 +0100	[thread overview]
Message-ID: <84342cda07aa41fb6f03a1dda815c22e1609bd44.camel@linuxfoundation.org> (raw)
In-Reply-To: <20200912164811.978100-1-mgloff@emacinc.com>

On Sat, 2020-09-12 at 11:48 -0500, Michael Gloff wrote:
> In order for the VERSION variable to be set, the
> top level Makefile should be used, which only
> builds the code in /src anyway.
> 
> Signed-off-by: Michael Gloff <mgloff@emacinc.com>
> ---
>  meta/recipes-core/sysvinit/sysvinit_2.97.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-core/sysvinit/sysvinit_2.97.bb
> b/meta/recipes-core/sysvinit/sysvinit_2.97.bb
> index 80ab9d70e7..98916f7f19 100644
> --- a/meta/recipes-core/sysvinit/sysvinit_2.97.bb
> +++ b/meta/recipes-core/sysvinit/sysvinit_2.97.bb
> @@ -24,7 +24,6 @@ SRC_URI =
> "${SAVANNAH_GNU_MIRROR}/sysvinit/sysvinit-${PV}.tar.xz \
>  SRC_URI[sha256sum] =
> "2d5996857519bfd8634d2e1debabb3238fb38440f65fbfdc46420ee8bdf25110"
>  
>  S = "${WORKDIR}/sysvinit-${PV}"
> -B = "${S}/src"
>  
>  inherit update-alternatives features_check
>  DEPENDS_append = " update-rc.d-native base-passwd virtual/crypt"

I don't understand what you're saying. Why do we need the VERSION
variable to be set? Does sysvinit not support a separate build
directory?

Can you rewrite the commit message so that someone who hasn't looked at
the code can understand what the problem is we're fixing, why its a
problem and why this is the correct solution.

Thanks!

Richard


  reply	other threads:[~2020-09-12 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 16:48 [OE-core][PATCH] sysvinit: Remove ${B} assignment Michael Gloff
2020-09-12 19:11 ` Richard Purdie [this message]
2020-09-12 19:46   ` Michael Gloff
2020-09-12 20:11     ` Andre McCurdy
2020-09-12 22:24       ` Michael Gloff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84342cda07aa41fb6f03a1dda815c22e1609bd44.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mgloff@emacinc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox