Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mingde (Matthew) Zeng" <matthew.zeng@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] openssh: skip unit tests to avoid Makefile errors
Date: Mon, 20 Jan 2020 11:08:13 -0500	[thread overview]
Message-ID: <875zh6f6vm.fsf@windriver.com> (raw)


As per do_compile_ptest first appeared in commit 1f7aaf76f4aa7875f05f4b838a5ec4594a4c35dc,
regress/unittests/ binaries are already skipped.

This will trigger a Makefile error when running ptest:
```sh
/bin/sh: line 4: /usr/lib/openssh/ptest/regress/unittests/sshbuf/test_sshbuf: No such file or directory
make: *** [Makefile:243: unit] Error 127
make: Target 'tests' not remade because of errors.
```

openssh/regress/Makefile:
```
tests:		prep file-tests t-exec unit
```

Therefore we do not `make tests` as it consists of unit tests, we
`make prep file-tests t-exec` instead.

Signed-off-by: Matthew Zeng<Matthew.Zeng@windriver.com>

---
 meta/recipes-connectivity/openssh/openssh/run-ptest | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-connectivity/openssh/openssh/run-ptest b/meta/recipes-connectivity/openssh/openssh/run-ptest
index daf62cca5b..e5270ceade 100755
--- a/meta/recipes-connectivity/openssh/openssh/run-ptest
+++ b/meta/recipes-connectivity/openssh/openssh/run-ptest
@@ -4,7 +4,8 @@ export TEST_SHELL=sh

 cd regress
 sed -i "/\t\tagent-ptrace /d" Makefile
-make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" tests \
+
+make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" prep file-tests t-exec \
         | sed -u -e 's/^skipped/SKIP: /g' -e 's/^ok /PASS: /g' -e 's/^failed/FAIL: /g'

 SSHAGENT=`which ssh-agent`
@@ -41,4 +42,3 @@ EOF
 	${SSHAGENT} -k > /dev/null
 fi
 userdel openssh-test
-
--
2.24.0


             reply	other threads:[~2020-01-20 16:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 16:08 Mingde (Matthew) Zeng [this message]
2020-01-20 16:12 ` [PATCH] openssh: skip unit tests to avoid Makefile errors Alexander Kanavin
2020-01-20 18:19   ` Mingde (Matthew) Zeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zh6f6vm.fsf@windriver.com \
    --to=matthew.zeng@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox