From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ni.com (skprod3.natinst.com [130.164.80.24]) by mail.openembedded.org (Postfix) with ESMTP id BD28D701E4 for ; Mon, 21 Jul 2014 18:44:46 +0000 (UTC) Received: from us-aus-mgwout1.amer.corp.natinst.com (nb-snip2-1338.natinst.com [130.164.19.135]) by us-aus-skprod3.natinst.com (8.14.5/8.14.5) with ESMTP id s6LIikR2017092; Mon, 21 Jul 2014 13:44:46 -0500 Received: from weregild.amer.corp.natinst.com ([130.164.14.198]) by us-aus-mgwout1.amer.corp.natinst.com (Lotus Domino Release 8.5.3FP6) with ESMTP id 2014072113444584-40706 ; Mon, 21 Jul 2014 13:44:45 -0500 From: Richard Tollerton To: Richard Purdie , Ben Shelton In-Reply-To: <1405966466.22985.101.camel@ted> References: <1405961628-25284-1-git-send-email-ben.shelton@ni.com> <1405961628-25284-4-git-send-email-ben.shelton@ni.com> <1405966466.22985.101.camel@ted> User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) Date: Mon, 21 Jul 2014 13:44:45 -0500 Message-ID: <87a982r1pe.fsf@weregild.amer.corp.natinst.com> MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 07/21/2014 01:44:46 PM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 07/21/2014 01:44:46 PM, Serialize complete at 07/21/2014 01:44:46 PM X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52, 1.0.14, 0.0.0000 definitions=2014-07-20_03:2014-07-18, 2014-07-20, 1970-01-01 signatures=0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 4/4] busybox: Allow busybox-mdev to RPROVIDES hotplug X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 18:44:49 -0000 Content-Type: text/plain Richard Purdie writes: > On Mon, 2014-07-21 at 11:53 -0500, Ben Shelton wrote: >> From: Richard Tollerton >> >> This is for symmetry with udev which also RPROVIDES hotplug. >> >> Signed-off-by: Richard Tollerton >> Signed-off-by: Ben Shelton >> --- >> meta/recipes-core/busybox/busybox.inc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc >> index bd66e4f..b4b9684 100644 >> --- a/meta/recipes-core/busybox/busybox.inc >> +++ b/meta/recipes-core/busybox/busybox.inc >> @@ -42,6 +42,7 @@ SYSTEMD_SERVICE_${PN}-syslog = "busybox-syslog.service" >> >> CONFFILES_${PN}-syslog = "${sysconfdir}/syslog-startup.conf.${BPN}" >> CONFFILES_${PN}-mdev = "${sysconfdir}/mdev.conf" >> +RPROVIDES_${PN}-mdev = "hotplug" >> >> RRECOMMENDS_${PN} = "${PN}-syslog ${PN}-udhcpc" > > Why add this? I'm curious what would actually use that naming? > > The RPROVIDES in udev was for backwards compatibility when hotplug > actually existed iirc, its long since dead? Sorry, this was a mild case of cargo cult programming on my part. I saw the RPROVIDES in the udev recipe, and while I couldn't find it ever being used, I couldn't preclude the possibility that some other layer somebody else would use might depend on it. I agree that AFAIK, this code is dead, and the patch can be dropped. > Cheers, > > Richard -- Richard Tollerton