Re: [PATCH] opkg/package/rootfs_ipk: allow overwriting OPKGLIBDIR

[Adrian Ratiu <adrian.ratiu@collabora.com>]

Hi

On Wed, 17 Jul 2019, Martin Jansa <martin.jansa@gmail.com> wrote:
> Why don't you overwrite it with an override? We're doing that 
> for years without any issues.

You mean a distro-wide override in a .conf?

Can you please point to an example?

>
> On Wed, Jul 17, 2019 at 12:01 AM Adrian Ratiu <adrian.ratiu@collabora.com>
> wrote:
>
>> Some distributions for various reasons (like for example mounting a
>> tmpfs over /var at runtime) can't use /var/lib to store the opkg
>> metadata, so a different path is required to have a functioning
>> package manager.
>>
>> ${localstatedir} can't be modified to something other than the
>> hardcoded value in bitbake.conf because other recipes depending on it
>> will fail to install.
>>
>> So the only recourse, which is also the least invasive, is to allow
>> distros to overwrite the OPKGLIBDIR variable just like they are also
>> allowed to overwrite OPKGBUILDCMD.
>>
>> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
>> ---
>>  meta/classes/package_ipk.bbclass         | 2 +-
>>  meta/classes/rootfs_ipk.bbclass          | 2 +-
>>  meta/recipes-devtools/opkg/opkg_0.4.1.bb | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/classes/package_ipk.bbclass
>> b/meta/classes/package_ipk.bbclass
>> index d1b317b42b..9f9da2f91d 100644
>> --- a/meta/classes/package_ipk.bbclass
>> +++ b/meta/classes/package_ipk.bbclass
>> @@ -14,7 +14,7 @@ OPKG_ARGS += "--force_postinstall
>> --prefer-arch-to-version"
>>  OPKG_ARGS += "${@['',
>> '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
>>  OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude
>> '.join((d.getVar('PACKAGE_EXCLUDE') or
>> "").split())][(d.getVar("PACKAGE_EXCLUDE") or "").strip() != ""]}"
>>
>> -OPKGLIBDIR = "${localstatedir}/lib"
>> +OPKGLIBDIR ??= "${localstatedir}/lib"
>>
>>  python do_package_ipk () {
>>      workdir = d.getVar('WORKDIR')
>> diff --git a/meta/classes/rootfs_ipk.bbclass
>> b/meta/classes/rootfs_ipk.bbclass
>> index aabc370cfc..e73d2bfdae 100644
>> --- a/meta/classes/rootfs_ipk.bbclass
>> +++ b/meta/classes/rootfs_ipk.bbclass
>> @@ -21,7 +21,7 @@ OPKG_PREPROCESS_COMMANDS = ""
>>
>>  OPKG_POSTPROCESS_COMMANDS = ""
>>
>> -OPKGLIBDIR = "${localstatedir}/lib"
>> +OPKGLIBDIR ??= "${localstatedir}/lib"
>>
>>  MULTILIBRE_ALLOW_REP = "${OPKGLIBDIR}/opkg|/usr/lib/opkg"
>>
>> diff --git a/meta/recipes-devtools/opkg/opkg_0.4.1.bb
>> b/meta/recipes-devtools/opkg/opkg_0.4.1.bb
>> index 8c48d3097c..c663eff13b 100644
>> --- a/meta/recipes-devtools/opkg/opkg_0.4.1.bb
>> +++ b/meta/recipes-devtools/opkg/opkg_0.4.1.bb
>> @@ -28,7 +28,7 @@ PACKAGES =+ "libopkg"
>>  inherit autotools pkgconfig systemd ptest
>>
>>  target_localstatedir := "${localstatedir}"
>> -OPKGLIBDIR = "${target_localstatedir}/lib"
>> +OPKGLIBDIR ??= "${target_localstatedir}/lib"
>>
>>  PACKAGECONFIG ??= "libsolv"
>>
>> --
>> 2.22.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>