Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mingde (Matthew) Zeng" <matthew.zeng@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] glib-2.0: add -dev dependencies to fix ptest failures
Date: Thu, 30 Jan 2020 15:06:31 -0500	[thread overview]
Message-ID: <87ftfw7lq0.fsf@windriver.com> (raw)

There are a number of ptest failures due to glib-genmarshal, glib-mkenums
and couple other executables not in the image. Since these
executables are in FILES_${PN}-dev, we add ${PN}-dev to ptest RDEPENDS.

When starting a glib ptest but decided to Ctrl-c interrupt midway,
./run-ptest cannot be restarted unless running `userdel glib2-test`
manually. Therefore adding a check prior to ptest will ensure the
ptest can be restarted.

Signed-off-by: Matthew Zeng<Matthew.Zeng@windriver.com>
---
 meta/recipes-core/glib-2.0/glib-2.0/run-ptest | 3 +++
 meta/recipes-core/glib-2.0/glib.inc           | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest
index fc50082c8e..7a231b514b 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest
+++ b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest
@@ -1,6 +1,9 @@
 #! /bin/sh

 set -eux
+if id -u glib2-test; then
+   userdel glib2-test
+fi
 useradd glib2-test
 su glib2-test -c 'gnome-desktop-testing-runner glib'
 userdel glib2-test
diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index f4aff297e5..7204fc908a 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -138,6 +138,9 @@ CODEGEN_PYTHON_RDEPENDS_mingw32 = ""

 RDEPENDS_${PN}-codegen += "${CODEGEN_PYTHON_RDEPENDS}"

+RDEPENDS_${PN}-ptest += "${PN}-dev"
+INSANE_SKIP_${PN}-ptest += "dev-deps"
+
 RDEPENDS_${PN}-ptest += "\
             coreutils \
             libgcc \
--
2.24.0


             reply	other threads:[~2020-01-30 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 20:06 Mingde (Matthew) Zeng [this message]
2020-01-31 13:38 ` [PATCH] glib-2.0: add -dev dependencies to fix ptest failures Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftfw7lq0.fsf@windriver.com \
    --to=matthew.zeng@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox