From: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
To: "Burton\, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH RESEND] kernel.bbclass: fix emit_depmod_pkgdata() workdir
Date: Thu, 11 Aug 2016 12:32:47 +0300 [thread overview]
Message-ID: <87oa4zmz0g.fsf@ni.com> (raw)
In-Reply-To: <87r39vn11t.fsf@ni.com>
On Thu, 11 Aug 2016, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
> On Wed, 10 Aug 2016, "Burton, Ross" <ross.burton@intel.com> wrote:
>> On 10 August 2016 at 16:58, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>
>>> bitbake commit 67a7b8b02 "build: don't use $B as the default cwd for
>>> functions" breaks the assumption that this function is running under
>>> ${B}. This causes build failures because System.map is under ${B}.
>>>
>>
>> For clarity, can the function simply always use absolute paths instead of
>> relying on cwd?
>
> Yes, but other functions inside this bbclass also rely on cwd being
> ${B}; should I modify only this one to absolute paths or modify all of
> these functions (do_shared_workdir, or do_strip) to maintain consistency?
>
Ah nvm, I've looked closer at them functions and their use of cwd = $B
makes sense so it doesn't need modyfing. I'll resubmit only this patch.
>>
>> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2016-08-11 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 15:58 [PATCH RESEND] kernel.bbclass: fix emit_depmod_pkgdata() workdir Ioan-Adrian Ratiu
2016-08-10 20:00 ` Burton, Ross
2016-08-11 8:48 ` Ioan-Adrian Ratiu
2016-08-11 9:32 ` Ioan-Adrian Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa4zmz0g.fsf@ni.com \
--to=adrian.ratiu@ni.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox