Re: [OE-core] [PATCH 2/2] qemurunner: Impove handling of serial port output blocking

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Purdie <richard.purdie@linuxfoundation.org> writes:

> On Wed, 2023-12-20 at 09:53 +0000, Alex Bennée wrote:
>> Richard Purdie <richard.purdie@linuxfoundation.org> writes:
>> 
>> > On Tue, 2023-12-19 at 16:44 +0000, Alex Bennée wrote:
>> > > Richard Purdie <richard.purdie@linuxfoundation.org> writes:
>> > > Yeah I'm only seeing A10/A11:
>> > > 
>> > >   o regression_1010.5 Invalid memory access 5
>> > >     regression_1010.5 OK
>> > >   o regression_1010.6 Invalid memory access 6
>> > > 
>> > >   WARNING: here A10
>> > >   WARNING: here A11
<snip>
>> > 
>> > How long does it take for the test data to "back up" and timeout? The
>> > logging thread should take a maximum of 2s to notice data not being
>> > read/handled on the serial port.
>> 
>> I don't think it goes around the logging loop more than once. I only
>> see:
>> 
>>   grep "got" build/tmp_trs-qemuarm64/work/trs_qemuarm64-trs-linux/trs-image/1.0/temp/log.do_testimage
>>   DEBUG: got [(12, 1)]
>> 
>> from the poll.
>> 
<snip>
>> I'll keep digging.
>
> I've merged the patches into master since they are helping the stdout
> issue and helped a number of issues others were seeing.
>
> In the final version of the patch I did fix an issue where the
> exception handling from the thread was not working so well, it does at
> least print a, exception/traceback properly now (in threadtarget()).
>
> One of the reasons I asked about the warnings was in case that was
> showing an issue, previously it silently failed.
>
> I can believe there are other issues hiding in here :/.

So the failure was due to an exception being thrown at:

  elif self.readsock.fileno() == event[1]:

when my config hadn't triggered its opening. A bit of defensive coding
and it works. See:

  Subject: [PATCH] qemurunner: more cleanups for output blocking
  Date: Wed, 20 Dec 2023 16:14:50 +0000
  Message-Id: <20231220161450.1422484-1-alex.bennee@linaro.org>

>
> Cheers,
>
> Richard

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro