Re: [OE-core][master][PATCHv3] Flac: upgrade 1.4.2 -> 1.4.3

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2023-06-28 at 13:26 +0530, Siddharth wrote:
> From: Siddharth Doshi <sdoshi@mvista.com>
> 
> License-Update: URL fix
> 
> Remove PowerPC related options no longer supported upstream.
> 
> Signed-off-by: Siddharth Doshi <sdoshi@mvista.com>
> ---
>  .../flac/{flac_1.4.2.bb => flac_1.4.3.bb}            | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>  rename meta/recipes-multimedia/flac/{flac_1.4.2.bb => flac_1.4.3.bb} (76%)
> 
> diff --git a/meta/recipes-multimedia/flac/flac_1.4.2.bb b/meta/recipes-multimedia/flac/flac_1.4.3.bb
> similarity index 76%
> rename from meta/recipes-multimedia/flac/flac_1.4.2.bb
> rename to meta/recipes-multimedia/flac/flac_1.4.3.bb
> index d3ece3f3cf..badb43db89 100644
> --- a/meta/recipes-multimedia/flac/flac_1.4.2.bb
> +++ b/meta/recipes-multimedia/flac/flac_1.4.3.bb
> @@ -5,15 +5,15 @@ BUGTRACKER = "https://github.com/xiph/flac/issues"
>  SECTION = "libs"
>  LICENSE = "GFDL-1.2 & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-3-Clause"
>  LIC_FILES_CHKSUM = "file://COPYING.FDL;md5=ad1419ecc56e060eccf8184a87c4285f \
> -                    file://src/Makefile.am;beginline=1;endline=17;md5=146d2c8c2fd287545cc1bd81f31e8758 \
> +                    file://src/Makefile.am;beginline=1;endline=17;md5=b1dab2704be7f01bfbd9b7f6d5f000a9 \
>                      file://COPYING.GPL;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> -                    file://src/flac/main.c;beginline=1;endline=18;md5=893456854ce6bf14a1a7ea77266eebab \
> +                    file://src/flac/main.c;beginline=1;endline=18;md5=23099119c034d894bd1bf7ef5bd22101 \
>                      file://COPYING.LGPL;md5=fbc093901857fcd118f065f900982c24 \
> -                    file://COPYING.Xiph;md5=3d6da238b5b57a0965d6730291119f65 \
> +                    file://COPYING.Xiph;md5=0c90e41ab2fa7e69ca9391330d870221 \
>                      file://include/FLAC/all.h;beginline=65;endline=70;md5=39aaf5e03c7364363884c8b8ddda8eea"
>  
>  SRC_URI = "http://downloads.xiph.org/releases/flac/${BP}.tar.xz"
> -SRC_URI[sha256sum] = "e322d58a1f48d23d9dd38f432672865f6f79e73a6f9cc5a5f57fcaa83eb5a8e4"
> +SRC_URI[sha256sum] = "6c58e69cd22348f441b861092b825e591d0b822e106de6eb0ee4d05d27205b70"
>  
>  CVE_PRODUCT = "libflac flac"
>  
> @@ -25,11 +25,9 @@ EXTRA_OECONF = "--disable-oggtest \
>                  "
>  
>  PACKAGECONFIG ??= " \
> -    ${@bb.utils.filter("TUNE_FEATURES", "altivec vsx", d)} \
> +    ${@bb.utils.filter("TUNE_FEATURES", " ", d)} \

If vsx and altivec are no longer needed, you should remove that line
entirely as it is pointless if it is empty.

The reason you didn't see an issue in testing is that you probably
didn't try MACHINE=qemuppc which uses altivec.

Cheers,

Richard


>      ogg \
>  "
> -PACKAGECONFIG[altivec] = "--enable-altivec,--disable-altivec"
> -PACKAGECONFIG[vsx] = "--enable-vsx,--disable-vsx"
>  PACKAGECONFIG[avx] = "--enable-avx,--disable-avx"
>  PACKAGECONFIG[ogg] = "--enable-ogg --with-ogg-libraries=${STAGING_LIBDIR} --with-ogg-includes=${STAGING_INCDIR},--disable-ogg,libogg"
>  
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#183547): https://lists.openembedded.org/g/openembedded-core/message/183547
> Mute This Topic: https://lists.openembedded.org/mt/99826072/1686473
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [richard.purdie@linuxfoundation.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>