From: Ross Burton <Ross.Burton@arm.com>
To: "rpjday@crashcourse.ca" <rpjday@crashcourse.ca>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] more ptest pedantry: why conditionally include "run-ptest" in SRC_URI?
Date: Mon, 12 Feb 2024 11:48:22 +0000 [thread overview]
Message-ID: <8C7A9199-D49B-4190-9D96-F060CD858C71@arm.com> (raw)
In-Reply-To: <8d71c0f-9120-85b7-80ce-d985aa557f8@crashcourse.ca>
On 12 Feb 2024, at 06:39, Robert P. J. Day via lists.openembedded.org <rpjday=crashcourse.ca@lists.openembedded.org> wrote:
> more annoying nitpickery ... here:
>
> https://git.openembedded.org/openembedded-core/tree/meta/recipes-extended/xz/xz_5.4.5.bb#n28
>
> it's not clear why someone would go to the trouble of conditionally
> including run-ptest in SRC_URI as i would have thought the only
> benefit would be to avoid the triviality of copying run-ptest into
> WORKDIR, but beyond that, i don't see what the point is, and that's
> the only recipe i've run across that bothers to do that.
>
> is there something more subtle happening here?
No good reason, and I’d approve a patch that removed the conditionals on the grounds of cleaning up the recipe and ensuring that there’s less conditional paths through the recipe.
Ross
next prev parent reply other threads:[~2024-02-12 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 6:39 more ptest pedantry: why conditionally include "run-ptest" in SRC_URI? Robert P. J. Day
2024-02-12 6:47 ` Robert P. J. Day
2024-02-12 10:04 ` [OE-core] " Alexander Kanavin
2024-02-12 11:48 ` Ross Burton [this message]
2024-02-12 12:17 ` Robert P. J. Day
2024-02-12 12:55 ` Alex Kiernan
2024-02-12 14:46 ` Robert P. J. Day
2024-02-12 15:00 ` Alex Kiernan
2024-02-12 16:11 ` Ross Burton
2024-02-13 11:21 ` Robert P. J. Day
2024-02-13 16:25 ` Alex Kiernan
2024-02-13 11:35 ` Robert P. J. Day
2024-02-13 15:23 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C7A9199-D49B-4190-9D96-F060CD858C71@arm.com \
--to=ross.burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox