public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Ricardo Ribalda Delgado <ricardo@ribalda.com>,
	 openembedded-core@lists.openembedded.org, jpewhacker@gmail.com,
	 pbarker@konsulko.com
Subject: Re: [OE-core] [PATCH v2 1/2] wic: Fix permissions when using exclude or include path
Date: Sun, 05 Apr 2020 08:01:47 +0100	[thread overview]
Message-ID: <8a556aedfe46e327c5d64d77c3b282f2108d12aa.camel@linuxfoundation.org> (raw)
In-Reply-To: <20200304144936.2559106-1-ricardo@ribalda.com>

On Wed, 2020-03-04 at 15:49 +0100, Ricardo Ribalda Delgado wrote:
> When parameters include_path or exclude_path are passed to the rootfs
> plugin, it will copy the partition content into a folder and make all
> the modifications there.
> 
> This is done using copyhardlinktree(), which does not take into
> consideration the content of the pseudo folder, which contains the
> information about the right permissions and ownership of the folders.
> 
> This results in a rootfs owned by the user that is running the wic
> command (usually UID 1000), which makes some rootfs unbootable.
> 
> To fix this we copy the content of the pseudo folders to the new
> folder
> and modify the pseudo database using the "pseudo -B" command.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo@ribalda.com>
> ---
>  scripts/lib/wic/plugins/source/rootfs.py | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)

I added these two changes to -next but we're seeing a test failure on
Fedora, twice now:

https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/834
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/831

I suspect its related to these patches but haven't confirmed that as
yet...

Cheers,

Richard


  parent reply	other threads:[~2020-04-05  7:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 14:49 [PATCH v2 1/2] wic: Fix permissions when using exclude or include path Ricardo Ribalda Delgado
2020-03-04 14:49 ` [PATCH v2 2/2] wic: Add --embed-rootfs argument Ricardo Ribalda Delgado
2020-03-05  9:33   ` Paul Barker
2020-03-05 12:26     ` Ricardo Ribalda Delgado
2020-04-03 19:52       ` Ricardo Ribalda
2020-04-07 17:47         ` Paul Barker
2020-04-07 18:19           ` Ricardo Ribalda
     [not found]           ` <16039C80250EF791.10037@lists.openembedded.org>
2020-04-08 10:28             ` [OE-core] " Ricardo Ribalda
2020-04-05  7:01 ` Richard Purdie [this message]
2020-04-05  7:21   ` [OE-core] [PATCH v2 1/2] wic: Fix permissions when using exclude or include path Ricardo Ribalda
     [not found]   ` <1602DB74B6717A3F.2403@lists.openembedded.org>
2020-04-05  9:56     ` Ricardo Ribalda
2020-04-05 11:04       ` Richard Purdie
2020-04-05 11:53         ` Ricardo Ribalda
2020-04-05 12:01           ` Ricardo Ribalda
2020-04-05 15:29             ` Richard Purdie
2020-04-05 15:44               ` Ricardo Ribalda
2020-04-06  9:00                 ` Richard Purdie
2020-04-06  9:03                   ` Ricardo Ribalda
     [not found]                   ` <16032F9D180FD5D7.1684@lists.openembedded.org>
2020-04-06  9:21                     ` Ricardo Ribalda
2020-04-06 13:48                       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a556aedfe46e327c5d64d77c3b282f2108d12aa.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jpewhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pbarker@konsulko.com \
    --cc=ricardo@ribalda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox