Openembedded Core Discussions
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Hongxu Jia <hongxu.jia@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] package.bbclass: only one hardlink of separated debug info file in each directory
Date: Fri, 24 Aug 2018 09:39:45 +0100	[thread overview]
Message-ID: <8ab2dfe5f21ed72bbf4da87126e6172b6d413ee2.camel@linuxfoundation.org> (raw)
In-Reply-To: <b6ef0030-8c15-7dee-e993-681b2aced85f@windriver.com>

On Fri, 2018-08-24 at 15:16 +0800, Hongxu Jia wrote:
> Hi RP,
> 
> With this fix, we could not use yesterday's workaround fix
> `git: create symlink rather than hardlink between bin/ and libexec/',
> 
> But it is no harm for us, btw, Ubuntu use symlink in git , and Fedora
> use hardlink in git

Thanks, I was thinking there probably was a problem in package.bbclass
which your change to git was working around and you've now fixed it!

I think I'd prefer to leave git using hardlinks so that we can
potentially spot problems like this in future. There are other recipes
that use hardlinks where the breakage may be more subtle (e.g.
e2fsprogs) so having some recipes using hardlinks is good.

I wondered if you'd fancy creating a new additional oqea test for this
debug hardlink issue so that we'd detect any problems in future? The
test I added was:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=318595754b66e8e4f3db1bce1ac086a2409e2eca

and with the addition of a few directories, it could probably be extended?

Cheers,

Richard






  reply	other threads:[~2018-08-24  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24  7:00 [PATCH] package.bbclass: only one hardlink of separated debug info file in each directory Hongxu Jia
2018-08-24  7:16 ` Hongxu Jia
2018-08-24  8:39   ` richard.purdie [this message]
2018-08-24  9:11     ` Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ab2dfe5f21ed72bbf4da87126e6172b6d413ee2.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox